This is a test on a random file to see if all compilers accept this.
Change-Id: I412aef57730d07c8e6e2710fee71d5eded326d48
Reviewed-on: https://gerrit.libreoffice.org/68896
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
This should be more maintainable.
Change-Id: I60ee68cd79f7a0627bcaf8fd34d3036124ea0f9e
Reviewed-on: https://gerrit.libreoffice.org/68914
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
In a specific case, Err:504 was emitted by COUNTIF when its 1st
parameter was #REF!. This value was written into pivot cache definition
when exporting to XLSX. Clearly Excel only expected propagated #REF!
there, emitted error to user, and dropped the pivot table.
This problem made XLSX pivot table cache generated by Calc unusable
by Excel, despite ECMA-376 Part 1, 18.10.1.27 tells that the error
value is application-dependent.
The change makes COUNTIF to propagate errors received in its 1st
parameter, instead of owerwriting them with own Err:504. This will
likely need to be extended to other functions, if similar problems
would arise.
Change-Id: I459fa163a0e3e5f2c658631d66e096f4d46b1ace
Reviewed-on: https://gerrit.libreoffice.org/68868
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
* Update helpcontent2 from branch 'master'
- tdf#53524 (compl) Minor tweaks in Help page.
Added ref to icons
minor updates on tags
Change-Id: Ia9812a5928554284a5a2fb5416983888e2437439
Reviewed-on: https://gerrit.libreoffice.org/68915
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
warn:vcl.schedule:22358:22358:include/vcl/task.hxx:107: Priority will just change after next schedule!
Just don't set the priority if it's already set to the correct value, so
we can avoid a warning each time the visible cursor is shown or hidden.
Change-Id: Ie11164db0af4cfba06a620c9b2426cb903af3887
Reviewed-on: https://gerrit.libreoffice.org/68907
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
... in SplitNode.
The problem is that first the new anchor position is set in the
SwFrameFormat, then SwDrawContact::DisconnectFromLayout() is called
(implicitly from its SwClientNotify()).
This then cause the a11y wrapper to be disposed and an event to be sent,
which then ATKListener::notifyEvent() immediately processes by
retrieving all of the children of the anchor SwTextFrame.
At this point, we get an assert from SwTextFrame::MapModelToView,
because the layout anchor frame is still the old one, but the model
format already has the new position, so the frame can't map the
anchor position.
Avoid this by explicitly disconnecting from the layout before setting
the anchor on the SwFrameFormat.
Change-Id: Iba8960729dd041e13de4963d1b2ab6b223c8a427
Reviewed-on: https://gerrit.libreoffice.org/68880
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
* Update helpcontent2 from branch 'master'
- Donation button and sticky header for Help
Task: https://redmine.documentfoundation.org/issues/2815
Header was made sticky on non-mobile by using position: sticky.
This was the only way to make it work with the grid without
carving magic numbers into stone. IE11 ignores it, but so what?
Donation text was made shorter.
The Google search and the donation button were wrapped in a
container to make it easy to haul them all over the place.
Lots of tweaks were made to the grid areas and the styles of
the bottom elements to make everything fit nicely in the new
markup order. The result was tested on IE11 to make sure it
degrades gracefully.
The Displayarea element had a fixed width (my old mistake),
which made the min-width: 960px layout look very uncool.
Change-Id: I131a1e82290bc3381c938acb4dc9dbc408fb2ba7
Reviewed-on: https://gerrit.libreoffice.org/68890
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Noticed this on console:
cpp: <macro>:1 C:/BLP/core/scp2/source/calc/registryitem_calc.scp:1261 \
Bad token \text/x-ms-iqy produced by ##
See https://bugs.documentfoundation.org/show_bug.cgi?id=111344#c9
Change-Id: If6b5b4ae90c1b0fb812a5e2cd87d17fc688d21c6
Reviewed-on: https://gerrit.libreoffice.org/68885
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
In SwXMLImport::SetConfigurationSettings() there is a list of settings
that will be ignored/not loaded form the file if IsLoadUserSettings()
is false, which is presumably not the default.
The beginning of this list is obviously settings that can be set via
Tools->Options, but the end is mostly a bunch of Word-compat layout
settings that cannot be set in the UI.
Let's assume some cargo-culting happened there (this function is tricky
and underdocumented anyway), and replace the end of the list with those
settings that have been added to Tools->Options->Writer->Compatibility
in the last years, since those can be called "user settings".
Change-Id: I6ea4a5da4033ca3512d71e4123b47d46e20bf596
Reviewed-on: https://gerrit.libreoffice.org/68803
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
SwXMLImport::SetConfigurationSettings() needs to handle only those
settings for which the default is different vs. old OOo/LO versions;
DisableOffPagePositioning however defaults to false, so we can just rely
on that default. The inverted bDisableOffPagePositioning check is
wrong.
(regression from fe3d5766fa3c42f6cf8d1ea47af820e0b1c1cf48)
Change-Id: I300fa597f58b586b49089bb555a00a6923862abe
Reviewed-on: https://gerrit.libreoffice.org/68801
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I18dc216a59a5770456b20162c881c8726e2f44b2
Reviewed-on: https://gerrit.libreoffice.org/68788
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
By implementing BTLR support in
SwTextFrame::SwitchVerticalToHorizontal() (Point version).
Cursor traveling now looks good: all of up/down/left/right direction
have the correct paragraph and character position for all the lrtb, tbrl
and btlr cases.
As a side effect this also fixes mouse click, where clicking above the
paragraph positioned the cursor at the bottom of the paragraph.
Explicitly add a test for the mouse case as well, given that I initially
planned to fix the keyboard part directly in SwCursor::UpDown(), where
the keyboard test would pass, but not the mouse one.
Change-Id: Iabeded3f03a64416cfcaf58e0438c4a1a793e662
Reviewed-on: https://gerrit.libreoffice.org/68886
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
detect static variables that can be made const.
Thanks to mike kaganski for suggesting this.
Here I introduce a new plugin feature - using markers
in nearby comments to disable the plugin for specific
vars.
Some of this stuff was old debugging code. I removed the stuff
that was older than 5 years.
Change-Id: I6ec7742a7fdadf28fd128b592fcdf6da8257585c
Reviewed-on: https://gerrit.libreoffice.org/68807
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Move XNamed Java tests to C++ for ScDataPilotItemObj.
Change-Id: I2fcffbd7e7329357ac30fa14716bf2bcf49c5666
Reviewed-on: https://gerrit.libreoffice.org/68891
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Prefix variable nMaxFieldIndex with m_ to show it's a data member of the
class.
Change-Id: I207b3552f460b3433af6892abb6c4693e990d7bb
Reviewed-on: https://gerrit.libreoffice.org/68887
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Regression from commit b160db926b574b7e9d6696d49dbbce8dd289aade
(tdf#96947 vcl opengl win: fix background of menu items w/ check/radio
marks, 2018-05-14), the problem was that GetMenuPopupMarkRegion() did an
unconditional downcast from ImplControlValue to MenupopupValue. This
looked safe, but when the extracted function was used in
WinSalGraphics::drawNativeControl(), then that argument was not safe to
downcast.
Fix the problem by switching to safe downcast, and returning an empty
rectangle (instead of a bogus one) on error.
This way the old bug stays fixed but fontwork popup menu works again as
well.
Change-Id: I2b69b9f2e6823850892ac73df78dac5c2f04ec03
Reviewed-on: https://gerrit.libreoffice.org/68883
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Even though in theory it was worse to get an exception and return an
empty Any for CommandBars, in practice there are not resources to
figure out why that change apparently then caused a crash in the
customer application. Let's hope that it doesn't actually need the
CommandBars object for anything essential.
This reverts commit 87b4bd61792b28fe475c71d4484cd219c1e533ae.
Change-Id: Id2ec3a7254c5dd5a36ce2d5e930a457b9abd44f1
Reviewed-on: https://gerrit.libreoffice.org/68881
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
This causes asserts from std::upper_bound in ooo26330-3.sxw (without the
fix to the initial expansion, when the fields all expand empty)
Change-Id: I1005e68d27f53986b9216541e0b26ce52082cf55
* Update helpcontent2 from branch 'master'
- tdf#102265 update Impress Help as Format - Page was moved
This is a complex task and the intertwined nature of Draw and
Impress does not help.
In the patches for tdf#84258 .uno:SlideSetup was created as an
alias for .uno:PageSetup. The corresponding menu items are
Slide - Properties in Impress and Page - Properties in Draw.
Currently some Draw help pages refer to the simpress/01/01180000.xhp
file. This file needs to be cloned under sdraw and the contents
of both files along with all references to them have to be
brought up to date.
The Impress Slide menu documentation needs to be fleshed out in
simpress/main0117.xhp and new files have to be created for the
individual menu item references.
The Impress Format menu documentation simpress/main0105.xhp
needs a big overhaul. The same is true for sdraw/main0105.xhp.
The Help for Draw's Page menu has to be created.
To find the interrelations, I use
find /path -name '*.xhp' -exec grep --color=always -Hi 'string' {} +
or with -type f instead of -name to get maximum coverage.
Change-Id: I5d130846da6640aeebab758c0f6dae2c78f9e355
Reviewed-on: https://gerrit.libreoffice.org/68830
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Include the numeric member id in the name. Hopefully makes it a bit
easier to interpret log files produced by LibreOffice or by the COLEAT
tool.
Change-Id: I7270b9538cf1a75db8972fb91eb57b931fe8e320
Reviewed-on: https://gerrit.libreoffice.org/68859
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I9dd7984affc4343f148c66077feaac19176adf51
Reviewed-on: https://gerrit.libreoffice.org/68769
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
