Commit Graph

387470 Commits

Author SHA1 Message Date
Stephan Bergmann
ddd77c84cf loplugin:stringconstant
Change-Id: Ie4554214e475da1bddba7ab0694ce23d1d93f06f
2016-02-02 16:53:23 +01:00
Stephan Bergmann
773da02e8d loplugin:staticmethods
Change-Id: Iad54f114c6443950af4341e1d40dd7dcca9fb8d7
2016-02-02 16:42:26 +01:00
Tor Lillqvist
4f68c279e4 Test for SSE2 at run-time on Windows
To run on ancient CPUs, we compile for Windows with -arch:SSE since
8bd6bf93b7 (August 2014). Thus
_M_IX86_FP gets defined as 1. This meant that LO_SSE2_AVAILABLE did
not get defined, and that we hardcoded tools::cpuid::hasSSE2() as
always returning false. That was hardly the intent.

Change-Id: I7ee34510a774dab865c8990b74b91a5284218a96
2016-02-02 17:21:20 +02:00
Caolán McNamara
4cbd8e7bf3 windows impl doesn't care if drawPolyLine LineWidth y != x
so I don't see that it makes much of a difference then
if the quartz or cairo one's don't either

Change-Id: Iabd65d617437aa747b910fcd2e84421413ed7db6
2016-02-02 15:06:50 +00:00
Caolán McNamara
5a8ec16bf5 move getCairoContext from X11CairoTextRender to X11SalGraphics
and simplify a little bit

Change-Id: I5a2faeb7e22ee5a0eaa4f05bc73fd92cbe2f5083
2016-02-02 14:57:52 +00:00
Caolán McNamara
1a1ee2f6e5 move CairoTextRender cleanup to callers
so releaseCairoContext is a mirror of getCairoContext, so callers that don't
need to flush can drop that explicit call

Not sure, now that I see it, how there's been no sign of any problem with no
damage of the affected text area under gtk3

Change-Id: I8e508160be4102c64a0ecdf5591b6999f9171c36
2016-02-02 14:56:17 +00:00
Caolán McNamara
11389cff11 rename drawSurface to releaseCairoContext
Change-Id: Ie5aac4a8b11daa2aba092923286fbbb2d76d4651
2016-02-02 14:53:22 +00:00
Caolán McNamara
c3224db8ba Related: tdf#97375 a cut doesn't refresh the editview
but a delete does. The diff from delete to cut is the
EnterBlockNotifications/LeaveBlockNotifications calls so try that

Change-Id: I10147043d6fe358bf2f4f4bd6877210b86cbbd1f
2016-02-02 14:52:34 +00:00
Stephan Bergmann
72c1fb8c3c Avoid unncessary, premature null deref
...when SfxTabPage::Reset (sfx2/source/dialog/tabdlg.cxx) calls into
DoApplyFlags/DoRest with a null rSet (but which apparently isn't actually used
then), e.g. upon "File - Export as PDF..." in Impress.

Change-Id: Ie2f255694212356fa8fc994287c45f2b4730a5bd
2016-02-02 15:46:33 +01:00
Oliver Specht
869c73d0d2 tdf#97051: prevent duplicate copy of SfxItemSet
the patch f7424ed710 introduced copying of
the input item set of SfxTabDialog so now the item set of the style must
not be copied anymore.

Change-Id: If4155ee5999f0c5cd2ac754578a2c1b5ec33b14b
Reviewed-on: https://gerrit.libreoffice.org/22022
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-02-02 14:41:55 +00:00
irem
e1cd15fbac tdf#91054 cleanup weirdo function prototypes
Change-Id: I9bc2ed0acdd9770777b04fa75372fd794d8494d7
Reviewed-on: https://gerrit.libreoffice.org/21990
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-02-02 14:13:52 +00:00
Michael Stahl
8dadefc35f xmloff: tdf#96147: ODF export: fix duplicate fo:background-color
... attributes that happen if both CharHighlight and CharBackColor
properties are used, because the CharBackTransparent property wasn't
taken into account, and combining the CharBackColor and
CharBackTransparent properties happens *after*
XMLTextExportPropertySetMapper::ContextFilter() runs.

Also, it looks like a transparent highlight wouldn't export properly but
apparently DomainMapper::getColorFromId() won't create such.

(regression from f880962f5b)

Change-Id: Ib628ef8bb377482f74fadb97c81afb95fbbf7184
2016-02-02 14:58:34 +01:00
Stephan Bergmann
98183c3381 ...these args are all default ones
Change-Id: I40b7635d45178760e2fdb81a6c2d910414455352
2016-02-02 14:23:01 +01:00
Caolán McNamara
758a50110a Related: tdf#91909 home/end don't work in impress text boxes anymore
partial revert of

commit 9149dbf173
Author: Yousuf Philips <philipz85@hotmail.com>
Date:   Fri Nov 20 09:40:59 2015 +0400

    tdf#91909 Add shortcuts to slide navigation

to get home/end working in text boxes again

Change-Id: I9960b94077c4c00d63483d3105d73f418cbcef0e
2016-02-02 13:10:31 +00:00
akki95
20e2d7e7d1 tdf#95408 -"Toggle" in Writer Navigator to be more explicit in what it toggles
Bug resolved. Removed toggle button from non-master documents.
Toggle button working for master documents only.
Changed toggle button tooltip to "Toggle Master View"

Change-Id: I7b77bae812ac208b0b93fff9e114b063d2ae2520
Reviewed-on: https://gerrit.libreoffice.org/21913
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-02 12:45:58 +00:00
Stephan Bergmann
4120449c86 Compiler warning battle
...where 05642b446c "-Werror,-Wconstant-conversion
(from 255 to -1)" caused MSVC to counter with "warning C4310: cast truncates
constant value"

Change-Id: I7d80825a01e49817d7989e00774fed1f162dea85
2016-02-02 13:41:33 +01:00
akki95
a78f074a0b tdf#70998 Termchange: Graphic/Picture->Image
Changed visible terms as required.

Change-Id: Id4335629977aa8512c753241d7c2203820716b73
Reviewed-on: https://gerrit.libreoffice.org/21857
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-02 12:39:43 +00:00
Pranav Kant
18fbddcca5 lokdocview: Handle password protected documents
Change-Id: I606a1112c8eb4c1cc4596d6947ce1223543cc87c
Reviewed-on: https://gerrit.libreoffice.org/21861
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-02 12:29:51 +00:00
Takeshi Abe
59aee037e3 starmath: Avoid C-style cast
Change-Id: Ie8ae44e1b90796033847a892474f4de64e7f9328
Reviewed-on: https://gerrit.libreoffice.org/21984
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-02 12:25:22 +00:00
akki95
3534e36140 tdf#96252 - UI Confusing wording in Slideshow settings > Type of slideshow
Change-Id: Iae8a1980bb5b42c14c280c4b6d860f70fb4639e8
Reviewed-on: https://gerrit.libreoffice.org/21946
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-02 12:03:25 +00:00
Caolán McNamara
ab5c427784 Resolves: tdf#97375 use Invalidate in all modes
makes the crash/hangs go away

Change-Id: I91a4391190ec7aa0ffa5e41a8c1eb86b4bb9c484
2016-02-02 11:51:35 +00:00
Stephan Bergmann
05642b446c -Werror,-Wconstant-conversion (from 255 to -1)
Change-Id: I9cce09bf729398a475d9d07fdfa002f325611546
2016-02-02 12:42:21 +01:00
Stephan Bergmann
3c51c3db18 Attempted fix for "Resolves: #i126762# Ignore dictionary not in specified...
...location."  Caused many crashed during "make check", when aLocaleNames is a
sequence of 17 ("ar-SA", "ar-DZ", ...), but aLcoations merely a sequence of 2
(".../dict-ar/ar.aff", ".../dict-ar/ar.dic").

From comments further down below, it looks like aLocations will always contain
exactly two entries ("also both files have to be in the same directory and the
file names must only differ in the extension (.aff/.dic)"), and that all the
aLocaleNames members share the same set of aLocations ("Thus here we work-around
this by adding the same dictionary several times. Once for each of its supported
locales"), so that it would appear to be OK to just check once for the existenceof aLocations[0].

(There is a check for

    if (aDictIt->aLocaleNames.getLength() > 0 &&
        aDictIt->aLocations.getLength() > 0)

below, so it might be that these can be empty, or it might just be "defensive
programming."  Play it safe, and check here that aLocations is not empty.)

Change-Id: I82bea6571983e397a9e164b294a5ba656b511a67
2016-02-02 12:40:06 +01:00
Caolán McNamara
f6c3c94297 Resolves: tdf#97495 fix SmElementsControl tooltips
instead of setting a single tooltip for the whole
panel area, wait for a tooltip request and specify
the area to which it applies.

Which is what other widgets that have different
tooltip areas do, and maps much better to the gtk3
tooltip system which functions like that too.

Change-Id: I56f452562c3c4d9dcec4109a8ee6168f34619472
2016-02-02 11:31:43 +00:00
Marco A. G. Pinto
33003d0fed tdf#97439 Enhance pt-PT autocorrect file
This patch adds 168 new entries to the pt-PT autocorrection.

Change-Id: I8a9233cd0d1a2eeca5861c6ca51f3d2121053085
Reviewed-on: https://gerrit.libreoffice.org/22024
Reviewed-by: Olivier Hallot <ohallot@collabora.co.uk>
Tested-by: Olivier Hallot <ohallot@collabora.co.uk>
2016-02-02 10:57:58 +00:00
Dennis Francis
b5c191c130 Fix for tdf#97084 : Scroll view to the ref boundary...
...but maintain the fix for tdf#96524

Change-Id: I35128843d13904e9e0cf9ded559c352acb3c7c46
Reviewed-on: https://gerrit.libreoffice.org/21559
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-02-02 10:17:30 +00:00
Miklos Vajna
50d3ea929e sw: -Werror,-Winconsistent-missing-override
Change-Id: I96ce357b1e5a7260c07872182763eaea22a7d0c3
2016-02-02 11:05:54 +01:00
Miklos Vajna
bd8610ebaf LOK: add Document::setClientVisibleArea()
... and implement it in Writer.

Otherwise there is no way we can perform e.g. page down in an expected
way. Without this, the core visible area depends on the zoom in the
document, and the client visible area can be something entirely
different.

Change-Id: Iadfb5a225da09a2551ffa41ddf503bb3d22b3eae
2016-02-02 10:56:40 +01:00
Miklos Vajna
9d8b330794 lokdocview: add a set_visible_area()
Change-Id: Ib63959ad64fe52b648e0c0d3fe6d49fb282d57ee
2016-02-02 10:56:40 +01:00
Kay Schenk
6691d78f1d Resolves: #i126762# Ignore dictionary not in specified location.
Damaged "registrymodifications.xcu" causing problems with backups and spell checker

(cherry picked from commit 983e71fa37e12fbae29eddc2b855ddaf6280cc0e)

Change-Id: I279275e11fb2ee6a223c7905652165d1b7a2e0ac
2016-02-02 09:35:29 +00:00
Maxim Monastirsky
11d605cc5a tdf#84843 Stop using PseudoSlots for drawing slots
Instead of fighting with this obsolete thing, let's
just kill it. This fixes disabling in read-only doc,
as well as pressed/unpressed states.

Change-Id: I4d06ba3395024ffd09d77c6d22653a2c5e227115
Reviewed-on: https://gerrit.libreoffice.org/22010
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-02 09:32:36 +00:00
Emmanuel Gil Peyrot
8b65dec8e0 slideshow: Make sure the slide is fully opaque in Honeycomb
On Windows, the text is rendered with 0 of alpha, which is an issue in
this transition as it enables GL_BLEND.

Change-Id: I45fe32ccf77854e758eddc33f300791d4cdd6904
2016-02-02 10:23:17 +01:00
Noel Grandin
98c343604d boost::hash->std::hash
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8
Reviewed-on: https://gerrit.libreoffice.org/21989
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02 09:20:47 +00:00
Rosemary Sebastian
04eba5f599 Export and import of file name field
Change-Id: Ic2c8ce0ff2a54079ef81f6ce2770497a9d22c7b6
Reviewed-on: https://gerrit.libreoffice.org/21902
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-02-02 09:10:43 +00:00
Oliver Specht
90dfa7cbca tdf#97374: prevent crash while updating SvxPageTitleField
with commit 2970ec8438 the check for
a valid pDoc had been removed

Change-Id: I644ee82a46ec4f047f1a1b6bff68c4b67e96c3d8
Reviewed-on: https://gerrit.libreoffice.org/22006
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2016-02-02 08:42:55 +00:00
Miklos Vajna
ef59f096a5 svx: prefix members of SvdProgressInfo
Change-Id: I23fa86080c001d3a78c3b7d7c49274f01444d9be
2016-02-02 09:17:15 +01:00
Tor Lillqvist
37b465b3ee Remove leftover printf-style %f
But seriously, who builds with OSL_DEBUG_LEVEL > 2?

Either debugging printouts inside such ifdefs are completely pointless
and should be removed, or then the information might actually be
useful, and the ifdefs should be removed, so that the information can
be selected to be printed using the normal SAL_LOG environment
variable mechanism (in a build where SAL_INFO is functional).

Change-Id: Ia5d2c7c7b525ed133fe3f077a005f583b8a856e7
2016-02-02 08:42:44 +02:00
aybuke
91c072b473 tdf#43157: Fix format string violations in OSL_TRACE etc.
Change-Id: Idffbfb78b2386020fd099077a67bf8a89917bdab
Reviewed-on: https://gerrit.libreoffice.org/21999
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-02 06:10:21 +00:00
Chris Sherlock
8e43d1c5d1 vcl: minor formatting
Change-Id: I7cc82556d0c1fe874bf112052300217a0162c5bb
2016-02-02 08:00:50 +11:00
Miklos Vajna
c1411517af vcl: -Werror=unused-variable
Change-Id: I544d42994bd46171d5d507af450cd1ca5f9c912a
2016-02-01 20:28:29 +01:00
Marco Cecchetti
d104ed1a64 lool - now the fill cursor type is mapped correctly
Change-Id: I6d89df49b9f740b7f81394938222261f25a50dba
2016-02-01 18:57:53 +01:00
Gabriele Ponzo
43adbc8489 tdf#96327: Fix accelerator for remote files
Change the accelerator from F to S, because it was conflicting with
file menu.

Change-Id: I1f3959ae12b09fb5d48a7379693c6afc1bafa906
Reviewed-on: https://gerrit.libreoffice.org/21898
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2016-02-01 17:57:01 +00:00
Miklos Vajna
c84e1e2521 lokdocview: call lok::Document::setClientZoom() after zoom change
This is similar to what is implemented in online.git's leaflet. If the
zoom factor changes, then inform LOK about it on the first keyboard hit.

Change-Id: I2db4ffed3897db5c852f4b8aea8f4e2d3500a25a
2016-02-01 18:56:23 +01:00
Miklos Vajna
dfe5531ec8 lokdocview: log lok::Document::postKeyEvent() arguments
Change-Id: I16e7c0fee34077d5bbb493d9d9502ff82355c2c6
2016-02-01 18:56:23 +01:00
Caolán McNamara
74ac2c25a7 work around lack of cairo_rectangle_int_t with basegfx
ditch the CAIRO_VERSION_ENCODE(1, 10, 0) + sub optional
damage rect and just use our always-available basegfx
foo here.

Change-Id: I680453180f4725ac37cabf38d71b935c99edf6c7
Reviewed-on: https://gerrit.libreoffice.org/21971
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-01 17:52:18 +00:00
Laurent Balland-Poirier
2387d277f7 Add icons for 'Save to Remote Server' (tdf#93038)
Sifr icon theme

Change-Id: Ic8cf19195ce48a4825e94ae31aee835555be1e0e
Reviewed-on: https://gerrit.libreoffice.org/21970
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-02-01 16:45:08 +00:00
Michael Stahl
8d0b06a69e configure: remove ---disable-randr-link
This looks obsolete, it was used in LibreOfficeLinux.conf since the
beginning but in fact since LO 3.5 it was broken and the vclplug_gen
was not actully dlopen()ing Xrandr.so but somehow magically "found"
the symbols anyway.

Change-Id: I81251a8fef0abac63183b0ff3533bb2331ca6f5a
2016-02-01 17:29:31 +01:00
Mike Kaganski
f8058b556d tdf#96993: remove obsolete vertical mirror hack from PDF import
Since commit ae0e830f9a, mirroring
is handled correctly in LO, so no need to handle it specially in
PDF import code. This obsolete handling causes double-mirroring.

Change-Id: Ia873f0426e444cafd80b24b7d209e90eb481d8f4
Reviewed-on: https://gerrit.libreoffice.org/21870
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-02-01 16:28:09 +00:00
Michael Stahl
0e5a0cd29c fix the --disable-randr-link build
This was borked since gbuildification of vcl in 2011 and the dlopen
code didn't even compile since commit
b5f1139427

Change-Id: Ieff22ed144d9d89e53dd956ce0dfea5e4d07ea13
2016-02-01 17:10:38 +01:00
Xisco Fauli
359f43f8e7 tdf#79163: SVGIO: Fix problem with opacity attribute
Opacity attribute didn't work because it was always set to 1.0

Change-Id: I3a2029ef23acf9d8c0f346e04341db33c6802b8e
Reviewed-on: https://gerrit.libreoffice.org/21911
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-02-01 16:02:38 +00:00