61 Commits

Author SHA1 Message Date
Noel Grandin
9c4ae2ac2b loplugin:unusedfields
Change-Id: I73e94fe2bcf6e206ae8f78380abf2a399aa6dc01
Reviewed-on: https://gerrit.libreoffice.org/78365
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-01 18:35:58 +02:00
Noel Grandin
5ae7908ece loplugin:unusedfields
Change-Id: I80ed513cf690f94bf4320b040b36d7f904c63482
Reviewed-on: https://gerrit.libreoffice.org/76233
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-24 15:36:24 +02:00
Noel Grandin
ac933bb93a loplugin:unusedfields
Change-Id: If1e0b32f2cce7678f454009c0180d7612b4fb7c6
Reviewed-on: https://gerrit.libreoffice.org/76119
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-23 07:49:07 +02:00
Michael Weghorn
adb3e60d3f kf5/gtk3_kde5 fpickers: Drop unused 'allowRemoteUrls'
Change-Id: I591bf9fbe6e22bedda5a94334130a4f674cd66e6
Reviewed-on: https://gerrit.libreoffice.org/76110
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-07-22 16:16:30 +02:00
Jan-Marek Glogowski
d3c6ac6d0f tdf#125922 rename kde5 to kf5 + plasma5
Just as the gtk3 plugin isn't named GNOME, rename kde5 to kf5, as
it is based on the KDE frameworks 5 libraries.

This also includes:
* a convenience alias to load the kf5 VCL plugin in case someone
  requests the kde5 plugin.
* keep convenience kde5 configure switch, but warn about it
* rename detected desktop from kde5 to plasma5

Change-Id: I6764a05b81a5edbf284484c234fee2649aacf735
Reviewed-on: https://gerrit.libreoffice.org/75313
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-07-21 23:22:46 +02:00
Noel Grandin
8303e7ed66 loplugin:unusedfields improvements
tighten up the only calling write-only methods part of the analysis

Change-Id: I5bc6fdf0ce51940653317e8a48c5241705c90d4c
Reviewed-on: https://gerrit.libreoffice.org/74022
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-14 11:37:35 +02:00
Noel Grandin
9ba797aa4f loplugin:unusedfields
Change-Id: I0bd600b59b2bc4b50eb2d32e95c9d1167fdf2eab
Reviewed-on: https://gerrit.libreoffice.org/73823
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-12 12:53:09 +02:00
Noel Grandin
aed5ce3547 loplugin:unusedfields
Change-Id: I9758fd606c7d4c251a3ac06661d642a47260b5fc
Reviewed-on: https://gerrit.libreoffice.org/73674
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-08 09:35:54 +02:00
Noel Grandin
82d018b402 loplugin:unusedfields
Change-Id: I8dc5a6ef84f43bad0bee26592b3a8e95c58e6f22
Reviewed-on: https://gerrit.libreoffice.org/72027
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-09 12:28:03 +02:00
Noel Grandin
3fe3bd8a90 loplugin:unusedfields
Change-Id: I321c8eefdc43979ef5fd3774c7094ac0dbcac417
Reviewed-on: https://gerrit.libreoffice.org/70657
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12 18:29:29 +02:00
Noel Grandin
7030a5860f loplugin:unusedfields
Change-Id: I31c953c8e4c1d4ec235ea318d0aa3b7cedaed1a3
Reviewed-on: https://gerrit.libreoffice.org/69683
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-26 07:30:13 +01:00
Noel Grandin
527977d5ca loplugin:unusedfields
Change-Id: Id6792f0955a25533d33f6da6ed8c3e993f578c3f
Reviewed-on: https://gerrit.libreoffice.org/69170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-14 08:48:04 +01:00
Noel Grandin
32c288d862 loplugin:unusedfields
Change-Id: Ifb2c9a2d1d7dcc0ed3e8458c1a13933ccababd4c
Reviewed-on: https://gerrit.libreoffice.org/68939
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-09 07:28:34 +01:00
Noel Grandin
5febdea1d1 loplugin:unusedfields improve write-only when dealing with operators
Change-Id: I3a060d94de7c3d77a54e7f7f87bef88458ab5161
Reviewed-on: https://gerrit.libreoffice.org/68132
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-21 12:04:28 +01:00
Noel Grandin
d9d8ec2521 loplugin:unusedfields
Change-Id: Ib41c168817c30ce11baf99c3f43005313fe484ff
Reviewed-on: https://gerrit.libreoffice.org/65496
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-21 07:26:25 +01:00
Noel Grandin
61dfcdda88 loplugin:unusedfields improve write-only logic
when dealing with modifications to container classes (e.g. std::vector)

Change-Id: Ic30043631007355ee9a3d9e3f9b6488b435182d6
Reviewed-on: https://gerrit.libreoffice.org/65050
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-13 08:37:58 +01:00
Noel Grandin
a8c1db5483 loplugin:unusedfields
Change-Id: I9f11c29a5bcb3512717ad01962f5645de96afe0b
Reviewed-on: https://gerrit.libreoffice.org/64918
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-11 10:37:52 +01:00
Noel Grandin
7e19677fe9 loplugin:unusedfields
Change-Id: I03e8814407fd8e345cb07ac433db4230b4d96e10
Reviewed-on: https://gerrit.libreoffice.org/64822
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-12-10 07:59:29 +01:00
Noel Grandin
3f88f1a6f4 loplugin:unusedfields
Change-Id: Ib3c797584493763773fd44fc3e8ac8b70ab0c221
Reviewed-on: https://gerrit.libreoffice.org/64326
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-30 12:22:47 +01:00
Noel Grandin
19c56b3bef loplugin:unusedfields in sw
Change-Id: I7a9184511df96bf2a6c40e39091010a7e2974ed6
Reviewed-on: https://gerrit.libreoffice.org/64143
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28 09:35:24 +01:00
Noel Grandin
1cfa1d9e10 loplugin:unusedfields
Change-Id: Id16846c19c57ec437a64146d0fa771c1bfc05135
Reviewed-on: https://gerrit.libreoffice.org/63028
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-08 07:38:35 +01:00
Noel Grandin
4bf2052e9d loplugin:unusedfields
Change-Id: I36d3e874aac2d57d4e6f24a0e89c9836704bb7a6
Reviewed-on: https://gerrit.libreoffice.org/62383
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-26 10:34:38 +02:00
Noel Grandin
fd56d5fd40 loplugin:unusedfields improvemements
treat fields touched in operator== as not being important, which
finds some more stuff (but also adds some false+)

Change-Id: I3f5d504d7dec7945a917afbcd58c92df74f03645
Reviewed-on: https://gerrit.libreoffice.org/62020
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-22 12:47:48 +02:00
Noel Grandin
afed3d177b loplugin:unusedfields
Change-Id: I4ebd1e89daf7ba5e6ab709f56c0fec5b49f50dd0
Reviewed-on: https://gerrit.libreoffice.org/61774
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-15 12:53:27 +02:00
Noel Grandin
ef0c0dfd77 loplugin:unusedfields
Change-Id: Iacce8e12a85f857192dc0520b795e1990a3612db
Reviewed-on: https://gerrit.libreoffice.org/61575
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09 12:30:36 +02:00
Noel Grandin
487fc22690 loplugin:unusedfields
Change-Id: I3d2cdd80b542dbdbd29971ef837111191809f081
Reviewed-on: https://gerrit.libreoffice.org/61282
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03 11:03:31 +02:00
Noel Grandin
be98dffedd loplugin:unusedfields
Change-Id: Idf6f7f2946eecada64d2a586194533840ec8cc63
Reviewed-on: https://gerrit.libreoffice.org/61248
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-03 08:26:20 +02:00
Noel Grandin
a6c7c2fe1b loplugin:unusedfields
Change-Id: I355fad84ed8765e8eb3fadb7c239b3b902ec1747
Reviewed-on: https://gerrit.libreoffice.org/61059
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-28 09:06:48 +02:00
Noel Grandin
40069adbc2 loplugin:unusedfields
Change-Id: Ic7871f3a40668ba73aa0f0067a45455920d55890
Reviewed-on: https://gerrit.libreoffice.org/60313
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11 18:18:12 +02:00
Noel Grandin
0e8e5c196b loplugin:unusedfields
Change-Id: I876183559a7d9f1e6d914fbf37d7ffe91459144e
Reviewed-on: https://gerrit.libreoffice.org/60278
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-11 09:39:44 +02:00
Noel Grandin
c83a807166 loplugin:unusedfields
Change-Id: I9ae44279f1cce06bd6868005fbb878ba4894aed7
Reviewed-on: https://gerrit.libreoffice.org/58706
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-08 09:30:23 +02:00
Noel Grandin
110a25fdc2 loplugin:unusedfields
Change-Id: I1827262ad95942cacff589929f9436f8383cf142
Reviewed-on: https://gerrit.libreoffice.org/57642
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-23 09:55:40 +02:00
Markus Mohrhard
026e2623f7 remove the GL based 3D charts
Change-Id: Ia578c71ae70aa0a85b49fa50138edf90f961b1e9
Reviewed-on: https://gerrit.libreoffice.org/57533
Tested-by: Jenkins
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-17 02:59:19 +02:00
Noel Grandin
d98f1e4e03 loplugin:unusedfields improve checking for write-only fields
we trade off a little accuracy for finding more possible write-only
fields.

Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269
Reviewed-on: https://gerrit.libreoffice.org/56715
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-02 08:47:48 +02:00
Noel Grandin
c37077578d loplugin:unusedfields
Change-Id: I7d9966d11f8272034523d9804ecf76e119552780
Reviewed-on: https://gerrit.libreoffice.org/55796
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14 21:57:20 +02:00
Noel Grandin
a75cc6348c loplugin:unusedfields
Change-Id: I42a55562747e6097c1193e285da67235f5364bea
Reviewed-on: https://gerrit.libreoffice.org/55610
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-11 21:31:48 +02:00
Noel Grandin
e9586cf0b5 loplugin:unusedfield improvements
improve the read-only check to ignore reads from fields that are guarded
by a boolean check, something like:
   if (field)
       field.foo();
this produces some false positives at the moment because I'm not
correctly handling the else block, but also some useful new dead code.

Change-Id: Id21fa1a56c171d09d979769b978b6eef14e8b695
Reviewed-on: https://gerrit.libreoffice.org/52664
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-10 10:38:23 +02:00
Noel Grandin
d9e6d51c7a loplugin:unusedfields
Change-Id: Id2dea1d3a56d5d3be03c5a2a4f2ef530a05f9b19
Reviewed-on: https://gerrit.libreoffice.org/52185
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-31 20:21:42 +02:00
Noel Grandin
e408e1d6d1 loplugin:unusedfields
Change-Id: Idd0cdd38718c3822db4d4b94ca2315a416bc27bb
Reviewed-on: https://gerrit.libreoffice.org/50997
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-10 12:04:41 +01:00
Noel Grandin
44d5188b2f loplugin:unusedfields
Change-Id: Id332557cbe7fb42d3d794612f26aa3ac161548d9
Reviewed-on: https://gerrit.libreoffice.org/50902
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-08 08:13:44 +01:00
Noel Grandin
21e0d8162a loplugin:unusedfields
fix the ReturnStmt check

Change-Id: I95076076bd1313d23798c4615ea12910c86ed9a8
Reviewed-on: https://gerrit.libreoffice.org/47309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-04 07:17:23 +01:00
Noel Grandin
48251502a8 loplugin:unusedfields
Change-Id: I84a7bcb891548416f0e1f1b20059f9b20c890d4c
Reviewed-on: https://gerrit.libreoffice.org/46686
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19 11:32:50 +01:00
Noel Grandin
e7f6fdd5c3 loplugin:unusedfields
The mnRequestedLength fields in formula/ were introduced in

    commit 6ef6dd0122b8e44d8547ec31f40def42173e4e41
    Author: Kohei Yoshida <kohei.yoshida@collabora.com>
    Date:   Wed Feb 26 14:32:57 2014 -0500
    Store the length of originally requested array size prior to
    trimming.

but then partially removed in

    commit d7f1f91b194da1cb96e66268ce7ef38602aa5754
    Author: Noel Grandin <noel@peralex.com>
    Date:   Mon Mar 3 13:29:43 2014 +0200
    remove unused code in formula/vectortoken

Change-Id: Ic56b6e42682131ee45df7838867145f980f3d601
Reviewed-on: https://gerrit.libreoffice.org/45571
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-01 08:13:06 +01:00
Noel Grandin
4887f9fe2d loplugin:unusedfields
Change-Id: Ie8a2c6462ddc708140e725847199c8234ab6b592
Reviewed-on: https://gerrit.libreoffice.org/44528
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-09 13:57:13 +01:00
Noel Grandin
31baba076f update unusedfields loplugin results
Change-Id: I4bdf5701fe9a4dec618440db1fe69e5aad7a60bb
2017-09-27 11:32:59 +02:00
Noel Grandin
1ff0f0ba29 improve unusedfields loplugin
(*) IsPassedByNonConst was completely wrong, not even sure why it worked
before.
(*) treat a field passed to operator>>= as being written to, but not
read

Change-Id: Id3a5f2f35222986fe5edba3f5a58215a1815d401
2017-09-18 09:45:15 +02:00
Noel Grandin
a84026031d loplugin:unusedfields
Change-Id: Ie26c52090d984c40cc108c9f20eb2ba31a866796
Reviewed-on: https://gerrit.libreoffice.org/42090
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-08 09:37:59 +02:00
Noel Grandin
4d41b2e42f loplugin:unusedfields
Change-Id: I81bcf4f56599146536ba8d66cc86fa5a08737298
Reviewed-on: https://gerrit.libreoffice.org/41556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-25 13:10:03 +02:00
Noel Grandin
4ed70b89aa loplugin:unusedfields
Change-Id: I21e538b8e9c7a5f0fb233019efac37a3555e3c93
Reviewed-on: https://gerrit.libreoffice.org/40438
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-26 11:15:52 +02:00
Noel Grandin
8045cef05c improve unusedfields loplugin readonly analysis
(*) better analysis of init-list-expressions
(*) fix analysis of calls to members, turns out there is no parameter
offset after all
(*) check for passing arrays to functions, need to check
  if the parameter is T* or T const *
(*) check for assigning field to a T& variable

Change-Id: Ie6f07f970310c3854e74619fe4fd02a299bf6879
2017-07-24 08:39:55 +02:00