Commit Graph

446656 Commits

Author SHA1 Message Date
Andrea Gelmini
1d8e99ba5e Fix typo
Change-Id: Id0bffcf1e58c7ecfff9814c00ec0de4e08a3d9ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88710
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14 15:06:42 +01:00
Andrea Gelmini
cb7bb12fb7 Fix typo
Change-Id: Ice82d39a0f523f3d535ecf2669edc3856c378e15
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88711
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14 15:03:11 +01:00
Caolán McNamara
8389dc88a4 split out MetricField value conversion functions
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 14:31:50 +01:00
Stephan Bergmann
f67e5ef9a5 Drop broken filter-out of -bind_at_load for Executable_soffice_bin on macOS
We generally use -bind_at_load ("Sets a bit in the mach header of the resulting
binary which tells dyld to bind all symbols when the binary is loaded, rather
than lazily." according to Xcode 11.3.1 ld(1) man page) since
4c9c1957cf "INTEGRATION: CWS geordi2q01: #i18350#:
join changes from CWS ooo11rc3" (lacking any explanation; later carried over
into solenv/gbuild/platform/macosx.mk).

And we filtered out -bind_at_load for Executable_soffice_bin (and others, back
then, which have become irrelevant by now) with
13be934b43 "INTEGRATION: CWS geordi2q14: #111934#:
merge CWS ooo111fix2" (again, lacking any explanation).

However, the latter was effectively broken when
6df9c479f5 "gbuildize desktop" rewrote it in
desktop/Executable_soffice.bin.mk as

  $(eval $(call gb_Executable_set_ldflags,\
      $(filter-out -bind_at_load,$$(LDFLAGS)) \
  ))

lacking an "soffice_bin," at the end of the first line.

Given that the soffice executable is apparently built with -bind_at_load ever
since 2011, without causing any issues, lets assume that filtering it out is no
longer necessary (if it ever was), and drop that.

(Maybe it was once necessary for some reason when the file system layout of OOo/
LO executables and dynamic libraries was different.  But today, the soffice
executable finds its dependent libraries, sal and sofficeapp, via
@executable_path just fine.)

Change-Id: Ifa379237cce4fa6d5ea0e2c1f1d84263f9007c50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88680
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14 14:04:04 +01:00
Xisco Fauli
0d3d40b266 tdf#121963: Add unittest
Change-Id: I33435643d1f4c0af8c846094f9f40845d6327b60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88627
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14 13:49:08 +01:00
Noel Grandin
407c45d54c tdf#130373 substitute color only works if left set to transparent.
regression from
	commit e27be9dfbc
	Date:   Wed Jul 3 15:07:44 2019 +0200
    move some Bitmap replace logic inside vcl

Change-Id: I0d985314367e26134c940e54f485db373d4c3642
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88675
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14 13:28:09 +01:00
Xisco Fauli
37d2715703 tdf#130556: Add unittest
Change-Id: Iab632cd3afe6bb1c5f90a700a452c6c4dad14261
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88617
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14 12:53:37 +01:00
Vasily Melenchuk
4e4ae855cb RTF/DOCX export: always set hyphenation to auto at document level
MS formats unlike ODT have also global setting for hyphenation
params. Previous approach was to set this global value depending
on default paragraph style settings. However, if hyphenation is
enabled ony for specific other paragraphs, hyphenation in MS Word
will not work.

Let's try to set global hyphenation value to "auto" and explicitly
enable/disable hyphenation on paragraph level.

Change-Id: I199fa80eb1204930e2640dac0e90802b6b98597b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88536
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-14 11:56:37 +01:00
Gabor Kelemen
f0c8312bc6 tdf#42949 Fix IWYU warnings in forms/
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I4afb3616c4f93155c187da11b2981b84d0984e9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87943
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-14 10:55:43 +01:00
Caolán McNamara
1b0397a519 use forward decls to reduce including unnecessary headers
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 10:00:09 +01:00
Caolán McNamara
1e57442fc9 weld SearchLabelToolboxController
and split out LabelItemWindow to reuse it

Change-Id: Ie14f1bdc6d8684db088c018afd341e10bee9d977
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88623
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:59:52 +01:00
Caolán McNamara
832a120473 don't need to include split.hxx or scrbar.hxx
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:59:36 +01:00
Caolán McNamara
29e9fe918d move dialog.hxx to vcl/include/toolkit
Change-Id: Ia3877f58b6e5ccc4fb1621e6b928638e0c850e7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88602
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:59:12 +01:00
Caolán McNamara
3f893b52e7 de-duplicate some code
Change-Id: I5900ee56cf5c80f00743060d1d22dfd3d383f1eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88622
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:58:49 +01:00
Caolán McNamara
3688235a8d weld SearchFormattedControl Item Window
Change-Id: Ifda9e514ae0329a756ec365a40ec1ccfcfea14ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88621
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:58:34 +01:00
Caolán McNamara
13b15ca63a weld MatchCaseControl Item Window
Change-Id: I33a8d96c449e653284d570ef534dcc453f27ad5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88619
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:58:21 +01:00
Caolán McNamara
3b081e6605 drop need to include vcl/edit.hxx in cui
Change-Id: I9479a7e8fc5b3897e48efc47dbae979137718bc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88618
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:57:16 +01:00
Caolán McNamara
91cc66dfa7 move VCLXFileControl to toolkit
Change-Id: I39bb417fe7e033a8f368fa04d4a30b2388bcddfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88615
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14 09:56:31 +01:00
Miklos Vajna
26df9f97bf xmloff: create SchXMLImport instances with an uno constructor
See tdf#74608 for motivation.

Change-Id: I6b4a78317e2b228296c8e4794c776b617920ccfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88630
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-14 09:13:34 +01:00
Andrea Gelmini
6a37c58ed7 Fix typo
Change-Id: Id300274f334b13b54d792ed5f9813522c5ca6018
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88668
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14 09:03:33 +01:00
Noel Grandin
a70b811114 deliver more useful message when I mess up a conversion to shared plugin
Change-Id: I6b5fb2977965b5366d698d960a2c75845cbd6ea6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14 08:59:34 +01:00
Stephan Bergmann
645fe53be0 tdf#122218: Hack to avoid blurry text with macOS SDK 10.15
...by setting the LC_VERSION_MIN_MACOSX load command's sdk value to n/a in the
soffice executable.

See <https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c167> for how
this helps, even though I have no idea why it helps.

(Adding that -platform_version linker option appears to generate warnings like

> ld: warning: passed two min versions (10.13.0, 10.13) for platform macOS. Using 10.13.

but which are probably harmless.)

Change-Id: I043498c7ff2d148d4a7e1e0e9d46241b638f2eba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88667
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14 08:13:00 +01:00
Noel Grandin
73f2637f5b make unusedmember use the shared plugin infrastructure
Change-Id: Ie2f5ada6e27544ca1bceabe6fcfe524063d3201f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88588
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14 08:08:54 +01:00
Noel Grandin
424a7f4045 add some more libs to libmerged
Change-Id: I9e1677c26cf082ed78765995bfa7f57ff50f8e7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88580
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14 08:08:17 +01:00
Noel Grandin
f7323482ae tdf#130573 labels exchanged in export to BMP
In the commit below, I removed the 1-bit dithered output,
so restore it.

regression from
    commit b5699cd01b
    Date:   Wed Feb 8 16:18:32 2017 +0200
    convert BmpConversion to scoped enum

Note that this bug has been around since LO5.4
which means that anyone who has adjusted their
setting in
   officecfg/registry/schema/org/openoffice/Office/Common.xcs
   with key BMP
runs the risk of having that setting now revert to its
prior (documented) meaning.

Change-Id: Ibbda8aefbac261ff37ffab7223714f5d0343c692
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88528
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14 08:07:54 +01:00
Samuel Mehrbrodt
b36dfb1135 Add tooltips for protect bookmark/field commands
Change-Id: I54954c20766bae2112571d92ad760f71d3bf2060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88611
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-14 07:26:30 +01:00
Jim Raykowski
350bf42540 tdf#89566 Replace navigation toolbox in Writer navigator
Replaces the navigation toolbox with the navigate by elements control.

Change-Id: Idba18e63ac29f37d8e614b6459ea67b71b65c885
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87005
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-02-14 05:37:00 +01:00
andreas kainz
cf96cb11e2 writer table sidebar update for smaler height and better layouting
Change-Id: Ide2b956879c469565b7fd220cdbe9a081bcaf145
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88572
Tested-by: Jenkins
Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-13 23:41:50 +01:00
Armin Le Grand (Collabora)
cfb9e6d997 Revert "Related tdf#130428: let's add some asserts"
This reverts commit 9811796aba.

Revert "tdf#130428 SfxItemState::UNKNOWN replacements"

This reverts commit cf4e87469b.

Change-Id: I976ade5e25db09e18297e46a5c92f8bc578399e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88610
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-13 22:43:44 +01:00
Maxim Monastirsky
98bc216781 Restore simple undo and redo buttons for the basctl module
Changed in commit c34edadf5b
("rework SvxUndoRedoControl to be a PopupWindowController"),
but the dropdowns do not work in that module.

These buttons used to be managed by SvxSimpleUndoRedoController,
but that's no longer the case. The reason is that
ToolBarManager::CreateControllers checks first for controllers
registered in Controller.xcu, and only if none found it checks
for sfx2 controllers. So SvxSimpleUndoRedoController by using
a sfx2-style registration, has no chance to be ever selected
for .uno:Undo or .uno:Redo.

This commit removes the unused controller, and restores the
previous behavior with the other controller.

Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-13 21:21:27 +01:00
Caolán McNamara
3b8c42a94b weld FindTextFieldControl
Change-Id: Ib5861855d37c72d2be2b11b77173a141db90444e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88614
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 20:55:46 +01:00
Caolán McNamara
8eab16d46f extract NaturalSortCompare from ListBox
Change-Id: I260c83778aea06eba9ae774739c6dc31fe5366d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88613
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 20:55:28 +01:00
Caolán McNamara
c32a61b8d4 nStyle is always set to WB_DROPDOWN | WB_VSCROLL
Change-Id: I8978d910cba881e8c0343111f600ba3f6aef9025
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88603
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 20:55:04 +01:00
Xisco Fauli
c4281cb41e tdf#130640: Revert "tdf#124983 In calc make printable page...
...borders also initially visible"

This reverts commit caeb7b1412.

Change-Id: I691934db79982c16bf0f43e7e38b00f3ab440a38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88616
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
2020-02-13 20:24:32 +01:00
Noel Grandin
abc0344a23 convert conststringvar plugin to shared infrastructre
and move the duplicated hasExternalLinkage function to a common location

Change-Id: I39a1990945666ff7a307b4ddd5e270da64ee1673
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88592
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-13 19:30:06 +01:00
Andrea Gelmini
a39a6476fd Fix typo
Change-Id: I63e1634114ca436d7fb4f8afe4cb7a0ac7824209
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88624
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-13 18:42:01 +01:00
Luboš Luňák
e0a94e9625 improve debugger/valgrind handling in watchdog
This way it'll avoid incorrect lock-up detection also if the debugger
is attached later when LO is already running.

Change-Id: I9b762ee439a62631036ad2f09f4396cca0b5ba6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88609
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13 18:21:55 +01:00
Caolán McNamara
a2e0abc7c6 factor out dialog hacks
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 16:51:11 +01:00
Caolán McNamara
119044e8c9 drop workben outdevgrind
Change-Id: I94978f84b45daec9ba7e782087e45182def234d6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88601
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 16:50:38 +01:00
Caolán McNamara
43b068aade use TopLevelWindowLocker for the lock other windows problem
Change-Id: Ic5d279ff9271ca24d9d32728d63322e8acc2037d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88599
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 16:30:05 +01:00
Luboš Luňák
e76bb4eab6 make sure SAL_SKIA=vulkan also overrides settings
Change-Id: I2933fec07b594c47520087664f50d48184122818
2020-02-13 16:02:35 +01:00
Luboš Luňák
7fcac1989c remove 'ATI' from the driver list
The ATI brand has not been in use for a decade, and it's confusing
to have both AMD and ATI there. All AMD gfx cards use the 0x1002
formerly-ATI PCI vendor ID, so just use AMD and that vendor ID.

Change-Id: I9d60f1e86fe12a2e0fe9548c7c912d2d1ecec240
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88534
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13 15:44:53 +01:00
Luboš Luňák
2b702f7436 make OpenGL blacklist file code generic and use it for Skia/Vulkan
Change-Id: Icc150b853f5d2d06afedcb7878f6a031aff57c2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88533
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13 15:44:39 +01:00
Samuel Mehrbrodt
4a5c627e61 Add uno cmd to protect bookmarks in a document
Change-Id: I7cc0dfa2b129d69d49b555495d77c2c710689e94
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88586
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13 15:39:22 +01:00
Marina Latini (SUSE)
618d1f1085 tdf#130563 Change the default dates format for Italian locale
Change the default dates format from the year with two digits
to the year with four digits avoiding misleading
interpretations of the years.
The change applies to:
it_CH, it_IT, fur_IT, lld_IT, sc_IT, vec_IT

Change-Id: Ib0d2d72e84a162c0e8daee8d4702173013e60af6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88462
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-13 15:36:14 +01:00
Caolán McNamara
bcd7eee9e0 weld ScZoomSliderWnd ItemWindow
Change-Id: I50ab530f24770dcb4df174e2a379b0d14d76b253
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88573
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 14:52:16 +01:00
Caolán McNamara
420e5a9ced use what gtk reports as the held buttons for mouse move
Change-Id: I52242eb652802913382551527763737d92127129
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88597
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 14:52:02 +01:00
Samuel Mehrbrodt
087d9191ab Add uno cmd to protect fields in a document
Change-Id: Ifb9f757111a6fcbb283d2350ed2ccd42de19d5df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88585
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13 14:49:15 +01:00
László Németh
ae7c689a80 chart: don't export LO_EXT hide-legend in ODF 1.2
Regressions from

commit 7869b3d6e4
(related tdf#51671, store new "hide legend"
feature also in ODF)

and

commit a96ec04a07
(tdf#130225 implement ODF export of deleted legend
entries of pie charts)

Change-Id: I1d2847ae3e3ab7ccfbdb3841d94a0c1d79ded31f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88593
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Reviewed-by: László Németh <nemeth@numbertext.org>
Tested-by: László Németh <nemeth@numbertext.org>
2020-02-13 14:04:11 +01:00
Caolán McNamara
69498bfcf6 toplevel might not be a GtkWindow, no need to cast to GtkWindow
Change-Id: I3347bcff6f32e8eb61186216373a950b45ab1765
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88596
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13 13:38:09 +01:00