There's a compatibilityMode in word/settings.xml in DOCX files:
https://docs.microsoft.com/en-us/openspecs/office_standards/ms-docx/90138c4d-eb18-4edc-aa6c-dfb799cb1d0d
If a document doesn't contain compatibilityMode, then the default
is 12, but the code for table indent import/export assumed that the
default is 15, so loading an ODF document and exporting as DOCX results
in wrong table indent when loaded in Word.
(regression from 9a31d1c83e08600507689dc18f6f0973bc7e4389)
Change-Id: I3ce32286473640e5b7e12b487aef5f123bfb8d12
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88408
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ia1ac2b3d254487f6b4e85b52eead13635d30a5af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88416
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Without this, we disable all the languages, because the env. variable is
not set.
Change-Id: If8f6a9ec6270391d1f8c2bf225c8ea4bb1aae688
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88220
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88367
Tested-by: Jenkins
so copy the data we need before it can do that
Change-Id: If35d7ba0f272475e82f969bd80c6ff44131a3d2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88376
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Regression from e49d2b31fb2020d065b4ad940d1031d07b10f32b (fdo#78939
[DOCX] Hang while opening due to incorrect modification of Style,
2014-06-06), the problem was that the 2nd sub-list of the bugdoc was not
restarted in Writer, while it was in Word.
The PR2 paragraph style inherits from the PR1 one and only that sets the
numId; tweaking the bugdoc to state the numId directly in PR2 would work
around the problem.
Fix the issue by improving DomainMapper_Impl::finishParagraph(), so that
it uses lcl_getListId() rather than calling
pStyleSheetProperties->GetListId() directly; since the previous knows
how to walk up the parent chain if needed.
Change-Id: I1c460919b0389d5b053b4ca1c9210279d6cd183c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88413
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
* Update helpcontent2 from branch 'master'
to 68ea04c5012484b5ca30a87a5b8f326e5f9708f2
- tdf#130064 adjustments in legacy positioning help page
- remove unnoticed empty paragraph and add bookmark branch
- double appearance in "apply" label, and change to "List" style
- add missing word
- improve "Load/Save" explanation (appears also for "Position"
and "Chapter Numbering"
- added related topic link to "Indenting Paragraphs" for both
"Position" pages
Change-Id: I8da3e6b5e70c37606eaa79850cde0d9c4b3d5db1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88390
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
Otherwise Master Document is detected as Writer,
causing crash when opening the customization
dialog, as the notebookbar tab isn't prepared to
handle the Master Document variant.
Change-Id: I872255c42517b4223fb31e2074e4d5d083c76e93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88344
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
In addition:
- .uno:BackColor was unused, and internally mapped to the same
id as .uno:DBBackgroundColor which is used and has a label. So
remove the former, and make the latter visible in the
customization dialog instead.
- .uno:DSBEditDoc is mapped to SID_EDITDOC, and handled by the
code, but has no label. On the other hand, the toolbar has an
.uno:EditDoc item, which has no mapping in reportdesign, but
happens to be mapped to SID_EDITDOC elsewhere. So assume this
was a mistake, and .uno:DSBEditDoc should be used instead of
.uno:EditDoc.
Change-Id: I9da2ed36167571627b32a4055b734847c3ea1e64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88342
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
* Update helpcontent2 from branch 'master'
to 6f892e6e9b43209dad3ee82ddd7bd4ea0d3b129f
- updating help for "Page number" on "Status Bar" help page
- changed section id from "seitennummer" to "pagenumber"
- single click opens "Go to Page"
- removed "link" in "pagenumber" section - because it simply goes
from the Status bar page to the page where the embed is coming from.
Change-Id: I23387937aea57811f85a9a9cf4a4f3a80932b4ac
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88150
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
when toggling one the other gets a click signal, but its too
early and the page size isn't set yet, making the dialog thing
the margins won't fit in the page
Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88383
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
From some reason it fails to be read from the versionrc; and I'm not
really eager to debug why...
Without this, only the dictionaries that do not mention the
OpenOffice.org-minimal-version are registered; which would be just 2 of
them.
Change-Id: I9fe0bc138eadbdcbe5e0d8231e7e90ef268163bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88219
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88366
Tested-by: Jenkins
...and try to register it for use - it's a bundled extension.
The attempt to use the Android's native spell checking failed because
the combination of gboard + google's spell checker makes every word in
the app appear as if spelled correctly.
I haven't found any easy way around that, so let's use hunspell instead;
but for that, we need to make the bundled extensions work on Android.
Change-Id: If6563e497f1d3085c26eda571567242b2c1f6181
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88217
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88364
Tested-by: Jenkins
- Update also to icons in Bullets and Numbering toolbar
Change-Id: Ifbd28ae3e1842047c39a9349d670b6e954dd2d62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88356
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
It's not used by the PCH, so it's safe.
Change-Id: Ia86bf0ff31bc40b81b10517f8abd33e9170dba2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88362
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
We generally sort sources for each target in LO, so make this
consistent/nicer :).
Change-Id: I4c8bc0d9e3f0b2d8b966bd90215c960c30ea2f86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88361
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
in htmlexport CUT on Windows with tradtional Chinese
as the system locale.
Libxml2 complaints about encoding:
Entity: line 2: parser error : Input is not proper UTF-8,
indicate encoding !
Bytes: 0xB4 0x49 0xA4 0xE5
- By default SvxHtmlOptions::GetTextEncoding() uses
SvtSysLocale::GetBestMimeEncoding() to decide the decoding,
where osl_getThreadTextEncoding() is used. That results in
big5 if you're using Windows with tradtional Chinese as the
system Locale.
- libxml2 expects the xml begins with "<?xm", and guesses the
encoding based on first 4 bytes of the content. So it always
falls back to utf8 in our test.
Change-Id: I48be9bf552ab6ea76f8baea7e48a8c02a7e8c2cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88260
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
This reverts commit 15664830235fd3d34dc633affa87824e5c10cb79.
Reason for revert: this was fixed meanwhile via
https://gerrit.libreoffice.org/c/core/+/86201
Change-Id: Id264bc09445cc00e059a243b8ccc53d9364c3ca9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88287
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
The rotation works in RTF export and DOC export, but not DOCX.
If a text field is rotated via SvxCharRotateItem, the w:eastAsianLayout
element gets written on the run that contains the fldChar begin,
but not the subsequent 4 runs that are written via
DoWriteFieldRunProperties(), because it doesn't write
m_pEastAsianLayoutAttrList.
It's not clear why that function manually writes a subset of the run
properties instead of simply calling WriteCollectedRunProperties()
to get all of them.
Change-Id: I6d8cacda4b62a6f6fdc77885149e7de8666e7200
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88196
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Both MSVC and Clang (with -building-pch-with-obj) generate one extra
object file for code from the PCH, saving repeated generating of this
code for every object using the PCH. This causes problems when
temporarily disabling PCH by doing 'make ENABLE_PCH=' (e.g. when
checking #include's are correct), as this object would no longer be
linked in, and objects not rebuilt with PCH disabled would still need
it.
This patch allows doing 'make BLOCK_PCH=1' instead, which will disable
PCH with the exception of this object file still getting linked in.
Change-Id: I8fcb150ef27ebb34118d62739a1a1558aa1a6f3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88341
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
