Convert ABS(x) to the equivalent, but
working Writer formula SQRT(x POW 2).
Note: this is a temporary conversion, which
supports only 1-level nesting of function calls.
Change-Id: I96ad01dc5ac26160792e6a4cb050e103c2ad7bca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100898
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Hopefully this would prevent in the future the sequences like what has
happened in the past, when first 9fceed463b
removed page dimensions, then 2a33c69b16
added them back when trying to provide better font defaults, and then
5d9348b136 changed the dimensions from one
standard to another...
Of course, this is just a simple solution, still not allowing one to use
custom templates when using ShellNew functionality.
Change-Id: I7b48fedad8ba7f85f8cfdd0f98ccb505c51d1e76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100899
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
"suspicious concatenation of string literals in an array initialization; did you
mean to separate the elements with a comma?"
Change-Id: I83828d8cc6f8ab9b0c1ca8a1c3fb528592c46504
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100897
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \
/data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \
/data/sbergman/lo-7.0/core/instdir/program/types.rdb \
>/data/sbergman/lo-clang/core/udkapi/type_reference/udkapi.idl
* no changes
LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \
/data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \
/data/sbergman/lo-7.0/core/instdir/program/types.rdb \
/data/sbergman/lo-7.0/core/instdir/program/types/offapi.rdb \
>/data/sbergman/lo-clang/core/offapi/type_reference/offapi.idl
* (XDcoumentHandler getting moved around now is a consequence of this being the
first fully-automated generation of the file again after the manual
modifications done by the preceding 214e6caf2c
"[API CHANGE] remove BasicImport UNO interfaces" and
ebb66ee09b "Fixed update of the reference rdbs
to libreoffice-6.4.0.3-buildfix1".)
Change-Id: I841b6b5a059c78750fa7f02f9276c6b6f86c9afd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100892
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Regression from commit d379d18666 (oox:
import WPS shape with text as shape with textbox, 2014-06-18), then
problem was that when undo restored text deleted by cut, we ended up
with an SwXShape that had no frame format.
Fix the problem by deleting the cached old UNO wrapper after changing
the association between a textbox's shape and text frame.
An alternative would be to handle errors better when the TextBox UNO
property is not of type bool, but that would still lead to silent data
loss, so don't fix the problem that way.
Change-Id: Id45ad292befc746e7c49a3b827c91efd069d29df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100876
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Keep original DOCX table formula during round-trip
using grab-bagging.
This is a temporary solution until fixing formula export
and a proposed solution for formula cannot be converted.
Follow-up of commit 68e74bdf63
(tdf133647 tdf123386 tdf123389 Improved .docx table formula import).
Change-Id: Ia4759e250c06e9cc0495fb0b57fccd1ee1f50da9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100872
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Otherwise it will fail assertion in SbxValue::Clear, because
SvRefBase::ReleaseRef would check that its current count is
not zero. In release builds, not doing this would leak.
Change-Id: I80dfc815f8a2b651ff290af10808212281abf246
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100879
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
This requires to reset Fixed flag temporarily, as in SbiParser::DefType
for non-image case.
And save the dimensions of the arrays in the custom types correctly:
the dimensions are numbered from 1, not from 0.
The existing unit test (that happened to not test anything actually)
was fixed.
Change-Id: I48c6b6d5d735d9972a2c0dd40345d5db75f87f39
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100877
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Although extremely unlikely, the Left Page style can have a different
Left and FirstLeft. In the even more unlikely case that the document
starts off using a left-page-only style, then the first header
would not show on the first page, but only on all of the following
left-only pages.
So, of course, we want the very first visible page in the document
to show the defined First header/footer.
Change-Id: I7e74fdc085509fb8d6b80f36d1402309b9db9404
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99862
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
VectorGraphicSearch was instantiated for the Outline, which is
the same for every view. The problem with this is that when we
have multiple views, the search would interfere with each other,
which is especially distracting in online when multiple users
connect to the same document and try searching.
This adds VectorGraphicSearchContext class, that is added to the
View, which makes the search view dependent and multiple instances
of VectorGraphicSearch are created, each one for its own view.
Change-Id: Ia0f34647b30b35f4ddb84d33353990d635756905
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100837
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
...when opening the Advanced options page and after adding a new JRE via the
"Add..." button, not only after highlighting another JRE line. (I suspect this
broke with 1aa246a8e8 "weld SvxJavaOptionsPage"
towards LO 6.4.)
Change-Id: I5f9b63e2d33a351eeef09712969b703f1e99ef7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100860
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
* Update translations from branch 'master'
to e8c9e70e057aec51c783b7230f1995020374d06f
- update translations for master
and force-fix errors using pocheck
Change-Id: I9e806cc79950a35df80dc1ffeab84cd5f18dc861
PDF vector graphic includes a page number, of the page that the
graphic is rendering. This however isn't remembered when swapping
out and back in the graphic, because the serialization format
doesn't include it.
This adds a version 2 of the serialization format, with an
additional page number (page index) attribute.
Also changes the GraphicTest to account for an additional 4 bytes
written and the change of the checksum.
Change-Id: Ic0fbfc4ad983f7880e06956da3b4664bd4b610d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100836
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
...and expand it to precisely match the three .dwo files, like had already been
done for the corresponding .o files. (Those .dwo files are generated when
-gsplit-dwarf is added to CLANGCXXFLAGS when manually overriding CLANGDEBUG=1.)
Change-Id: Ib6f1c505c754d54201273f08f987a9451af75bc4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100855
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Converts table formula syntax from MS Word to LibreOffice.
This version uses the list separator of the document for the
formula regexen; however, it does not convert the decimal or
list separators in the case where the person opening the document
is using a different locale from the author.
Change-Id: I9600a0bea060a76705a7ad6b051ed4fdd50b9d40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98614
Tested-by: Jenkins
Tested-by: László Németh <nemeth@numbertext.org>
Reviewed-by: László Németh <nemeth@numbertext.org>
getting configured, we already ignored them for painting, do the
same for the size-requests it output from our internal configuring
Change-Id: I4c0153535459b089ba6c31e3d9f09bfae2545806
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100824
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
...plus addressing follow-up loplugin:stringconstant when inlining the literals
at their sole call sites
Change-Id: I727e2d3fe53e85af328afc5fba92e52fb63c49b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100839
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
And while at it, merge the change from e2bd5afd72
"Make the C++/UNO bridge work to some extent on macOS on arm64" into the
existing code in a better way, reviving the assertion that openMax will be non-
negative when entering the loop.
Change-Id: I4b4e173a79ae6a0bbbf07df87d46761e86f460c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100841
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
Otherwise the transparency gets converted into b&w mask here before
applying the gradient. Required for tdf#134052.
Change-Id: Ife00f75024f7d776fdb11e16fcafbd237f07eb04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100830
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
which was dropped by
commit bba8e5aa6d
Date: Thu Mar 1 21:00:24 2018 +0100
tdf#116070: Use a valid PaM when confirming the dialog.
when fixing
commit 34527cec54
Date: Tue Jan 16 18:54:19 2018 +0100
lokdialog: Convert the Format -> Paragraph... dialog to async exec.
so, go back to using pPaM instead of rWrtSh.GetCursor but make a copy
of pPaM to avoid the crash of tdf#116070
Change-Id: I0aaaf5173c6be47dd306b77eacbb07d0e1c4eaf1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100670
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
