Commit Graph

397218 Commits

Author SHA1 Message Date
Rosen
dad35b0463 tdf#96505 Get rid of cargo cult "long" integer literals
Change-Id: Ic1602a57d1662cb30b2339de9eeb6483fdfbef37
Reviewed-on: https://gerrit.libreoffice.org/29242
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-09-25 07:14:33 +00:00
Gulsah Kose
7b8832ff97 tdf#101390 Add Arrows toolbox functions on calc drawingbar.
Calc arrows toolbox includes following commands
.uno:LineArrowEnd
.uno:LineCircleArrow
.uno:LineSquareArrow
.uno:LineArrows
.uno:LineArrowStart
.uno:LineArrowCircle
.uno:LineArrowSquare
.uno:Line

Change-Id: I09c93447baeafd3f7d4993117458d4585d21cbaf
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/29021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-25 06:59:32 +00:00
Markus Mohrhard
1a4555f3b3 fix the OpenGL selection logic
Now OpenGL is again not used on the build bots.

Change-Id: I7369394c44ab1e16135e2b22f7f8effca0f25d3c
2016-09-24 23:51:31 +02:00
Maxim Monastirsky
a05b675852 tdf#102266 Try to keep HUD up to date
Recent HUD versions don't seem to support the activation
callback, so we have to update menus in the background.

(regression of 15436c009e)

TODO: Is this manual iteration in GtkSalMenu::SetItemText
worth it, or maybe simply calling Update() will be good
enough, too?

Change-Id: I7f08c3518e1767915d84036cdce7f678961595ef
2016-09-25 00:06:47 +03:00
Markus Mohrhard
9aef73aa45 show correct command to execute the test
Change-Id: Ic7515c1d43737fb6864228d37be1b356acecfdc3
Reviewed-on: https://gerrit.libreoffice.org/29253
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-09-24 18:49:17 +00:00
Mark Hung
e23434e5af Remove Chinese comment in svl/qa.
The Chinese characters in the comment caused a compiler warning that
it can not be represented in cp950 codepage and forbid
OUStringLiteral1 concatenation. Replacing it with meaningful English
comment so others can understand it.

Change-Id: Ibc571e68ee5d65a89e385d79962db0fd6b1298cc
Reviewed-on: https://gerrit.libreoffice.org/29246
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-24 17:03:01 +00:00
Caolán McNamara
ad4026693a this is a (dubious?) compareToIgnoreAsciiCase not compare, so restore
Change-Id: I2c4c4d20f2f2c06310b926fb573ba41820022b43
2016-09-24 14:12:39 +01:00
Henry Castro
918834c04f sc lok: avoid full invalidate tiles
Change-Id: Idd49dc61ba8dbd7af42f641bb019cf83814f9e8d
Reviewed-on: https://gerrit.libreoffice.org/29240
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-09-24 12:35:24 +00:00
Caolán McNamara
88c7f08c49 coverity#1373358 Unchecked dynamic_cast
Change-Id: I96526a735c0adb4c20c463f73c34701a9fafb76b
2016-09-24 12:17:59 +01:00
Caolán McNamara
dd691312a3 we shouldn't need explicit lt_rtl_OUString, etc things anymore
Change-Id: Ibeec3fcc353e07e61fb2c838b318e0a04081ce2c
2016-09-24 12:15:13 +01:00
Michael Meeks
3be5deadcb tdf#91043 - vcl: gtk file picker should tolerate empty filter list.
Apparently LibreLex creates a dialog through UNO and sets no filters.

Change-Id: I518beef6f9c6ebab0d2e49bda78a33a283ad93d3
Reviewed-on: https://gerrit.libreoffice.org/29238
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-09-24 10:36:32 +00:00
Jan-Marek Glogowski
c540ae79e0 MM don't crash on canceled SHELL documents
We show canceled documents, as long as there wasn't an error.

Change-Id: I821f89bc9355df5b2223876ad52fee2a717e670a
2016-09-23 23:25:50 +02:00
Jan-Marek Glogowski
3c4dfb872d tdf#94987 Create directories for temp filenames
Per default a temporary file is construted from a path and a leading
pattern for the filename. For mail merge the filename can be read
from a database column. If the path is not existing, a temporary
directory is created.

Normally the temp file function would fail, if the filename contains
a slash and the sub-directory of the filename doesn't exists as a
subdirectory of path.

To implement tdf#94987, this adds an option to the temp file class
to create the parent directories of the filename pattern.

Change-Id: I02bf34294dac85598ee153d8cfcf00bc5d7775af
2016-09-23 23:25:49 +02:00
Jan-Marek Glogowski
260cd3aeea MM account next record fields for progress dialog
When calculating the maximum document count, we were not accounting
"next record" fields in the document, like in labels etc.

Also any selection of records was ignored.

Fixes accounting part of tdf#101841.

Change-Id: I703d2186d44d2e5426c4af0d4b2d89e0fe820039
2016-09-23 23:25:49 +02:00
Jan-Marek Glogowski
178a23a827 MM just increment after a successful next record
This correctly counts the record id from 1, while using 0
for the first item in the selection array.

Change-Id: I363eab048cb041bf46454ef685baab1eb3b2138a
2016-09-23 23:25:49 +02:00
Jan-Marek Glogowski
971947b38d tdf#101822 Revert "vcl: Stop-gap solution to ...
... start the gen / kde / kde4 plugins again."

The patch was just hiding the real bug and introducing others,
Ihe original bug is now fixed in all the X11 based VCL plugins,
so it can be reverted.

This reverts commit 3780029024.

Conflicts:
	vcl/unx/generic/app/saldisp.cxx

Change-Id: I95bea07e29293aaab178e30b5fb3cfe089d2d28f
2016-09-23 23:25:48 +02:00
Jan-Marek Glogowski
06283e7b00 tdf#101822 X11 SalDisplay init => AfterAppInit
This fixes all X11 based VCL plugins to move display
initialization  into AfterAppInit (gen, TDE, KDE4),

This is done by moving input method and display into
SalXLib, so they are available in AfterAppInit.

Otherwise the configmgr service won't be available in
SalDisplay::BestVisual.

Change-Id: I9380075b9770bceb8f453bbcb7fe31291634ff89
2016-09-23 23:25:48 +02:00
Jan-Marek Glogowski
3bc2b8c5e0 tdf#101822 Always de-zombie the glxtest process
Make sure we wait for the glxtest process.

Change-Id: I143290b80ba83e35f8d0f95d133c25178c5fe563
2016-09-23 23:25:48 +02:00
Jan-Marek Glogowski
8dc174178f Clarify KDE4 and TDE config variables
The configure flag is already --enable-kde4, so rename most build
and configure variables, including the config headers, and the
build module to include the major number.

Also rename the TDE MOC stored as $MOC to $TDE_MOC to prevent
conflicts.

Change-Id: Ib947ae4b80349cc52eac7812cb93e8a42606b526
2016-09-23 23:25:48 +02:00
Jan-Marek Glogowski
f486329a03 TDE fix some clang plugin based warnings
Change-Id: I3b44038e8a889e4c13126fd8d721e53e71ea9ec6
2016-09-23 23:25:47 +02:00
Tor Lillqvist
e44b034512 tdf#102382: nextEventMatchingMask should only be called from the Main Thread
So don't then unless we are on the main thread.

Change-Id: I6ba52ed7db5d73a4c1c6acf10bdf254a6f959da8
2016-09-24 00:18:11 +03:00
Michael Stahl
41602324b0 vcl: C++11 is awesome, they said! it's a whole new language, they said!
Change-Id: I96f00bd00ffcfea8ca026aacbaacf9539e327eff
2016-09-23 20:20:47 +02:00
Stephan Bergmann
09a77ceaf6 cid#1371232: Add move semantics
Change-Id: I8bd9a62da64adfc52be9ba954eb8dbc92d8ecc77
2016-09-23 18:33:48 +02:00
Stephan Bergmann
c53af84c9c cid#1371196: Add move semantics
Change-Id: I7bf2d6f5e5b1d10cde210c814567017680c6a74e
2016-09-23 18:33:34 +02:00
Stephan Bergmann
4c1823923f cid#1371304: Add move semantics
Change-Id: I60051e720e816b1bd72193cbc028ce7264ba1e6a
2016-09-23 18:33:11 +02:00
Stephan Bergmann
6b51e526b7 "// not impl" -> "= delete"
Change-Id: Ide848d53564a4c4f822ae3875102ee09f03e3ce5
Reviewed-on: https://gerrit.libreoffice.org/29232
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23 16:29:08 +00:00
Julien Nabet
5333743d3b tdf#100994: use CGContextStrokePath instead
This is a blind fix attempt to fix "Freeze when first action after launch with OSX Sierra with iMac 5K"

I started from bt:
frame #9: 0x00007fffbe094cf6 CoreGraphics`CGContextDrawPath + 183
frame #10: 0x0000000102b16cda libvcllo.dylib`AquaSalGraphics::drawPolyLine(unsigned int, SalPoint const*) + 330
frame #11: 0x0000000102929039 libvcllo.dylib`OutputDevice::drawPolyLine(tools::Polygon const&, LineInfo const&) + 361
frame #12: 0x0000000102928d30 libvcllo.dylib`OutputDevice::DrawPolyLine(basegfx::B2DPolygon const&, double, basegfx::B2DLineJoin, com::sun::drawing::LineCap, double) + 768
(see https://bug-attachments.documentfoundation.org/attachment.cgi?id=127502)

then:
http://stackoverflow.com/questions/32871234/how-to-make-kcgpathstroke-work-in-swift-2
which advises to replace:
 CGContextDrawPath(ctx, kCGPathStroke)
by
CGContextDrawPath(ctx, .Stroke)

and finally this:
http://stackoverflow.com/questions/37838578/how-to-stroke-a-cgpath
which advises to directly use this:
CGContextStrokePath(context)

Change-Id: I99f9800c39f18d16488f7ef4114a71722f9b8123
Reviewed-on: https://gerrit.libreoffice.org/29194
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-23 16:20:34 +00:00
Miklos Vajna
ecdec24c03 tdf#102384 sw: avoid moving cursors of other windows in SwTextNode::Update()
There is a list of exceptional SwIndex containers in that member
function, like bookmarks, at-char anchored fly frames, etc. If we're
growing (so basically in the safe case), don't touch the cursors of
other windows, either.

This helps to avoid the surprising "I didn't do anything and my cursor
moved" behavior.

Change-Id: I9941fdcb6b7ad4b6e18a321cecc72fdf73d917fd
2016-09-23 18:17:24 +02:00
Caolán McNamara
d17d7c63d2 coverity#1371156 Missing move assignment operator
Change-Id: I187bc61678b5283843227612c243c5a09d0e7eb1
Reviewed-on: https://gerrit.libreoffice.org/29227
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-23 16:14:41 +00:00
Caolán McNamara
c136c97875 coverity#1371219 Missing move assignment operator
Change-Id: I72ed6082b561079b45e82d8258fa1abbe23117e2
Reviewed-on: https://gerrit.libreoffice.org/29228
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-23 16:13:54 +00:00
Michael Stahl
3de2567853 vcl: Apple clang segfaults on "(", the "{" seems to work better
Apple LLVM version 5.1 (clang-503.0.40) (based on LLVM 3.4svn)

Change-Id: Ib9c8639d4c821a39afb6b071ccd6c7072e6f9e7c
2016-09-23 17:25:00 +02:00
Noel Grandin
3e22dfa5eb convert formula error codes to scoped enum
Change-Id: I5ff214bf1ec9031e30344bc125bc99916fd11bfb
Reviewed-on: https://gerrit.libreoffice.org/28897
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23 15:22:38 +00:00
Eike Rathke
7d8196ea2f perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related
There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.

To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.

For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.

Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23 15:14:03 +00:00
Stephan Bergmann
751689283c These functions wouldn't be implicitly declared/defined, anyway
Change-Id: Icd8531a6665b83c801b2f1e62dea5e8c45b06f00
2016-09-23 17:13:13 +02:00
Michael Stahl
fcdf75d946 Makefile.in: check JAVA_HOME/bin, not JAVA_HOME/include
On Mac OS X 10.8, the directory contains "bin" but not "include", so it
re-runs autogen.sh all the time.
JAVA_HOME=/System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home

Change-Id: I9065c8daef47df535f60267fc2c3e7cb23fc3910
2016-09-23 17:07:24 +02:00
Michael Stahl
7ac64b9afa fix denglish comment
Change-Id: I118e06b9664bdfc82de3c75471c28ec8e5dd84d2
2016-09-23 17:07:24 +02:00
Aleksandr Andreev
a303b53b3f Updating cu collation data for Unicode 9.0 and CLDR 30
See http://unicode.org/cldr/trac/changeset/12851

Change-Id: Idce0985c3015a0bfc24cb44a5abdf0eb86e5d183
Reviewed-on: https://gerrit.libreoffice.org/28969
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23 13:24:25 +00:00
Stephan Bergmann
18cd08ae42 cid#1371162 etc.: Move semantics for cppumaker-generated UNO exception classes
For UNO ABI reasons, these classes need to be CPPU_GCC_DLLPUBLIC_EXPORT (so
their RTTI symbols get exported), so they are careful to explicitly declare any
special member functions that would otherwise be declared implicitly, to mark
them CPPU_GCC_DLLPRIVATE.  But for LIBO_INTERNAL_ONLY, we always use
-fvisibility-inlines-hidden (except for MSVC, where it doesn't matter, as
CPPU_GCC_DLLPRIVATE expands to nothing there, either), so can leave those
functions implicitly declared, so not to prevent move ctor and move assign op
from being implicitly declared.

This covers cid#s 1371143, 1371162, 1371185, 1371189, 1371290, and 1371308.

Change-Id: I468088750a02f85a4790d956c37f4c30de03f00c
2016-09-23 15:23:52 +02:00
Pranav Kant
4151c09d9a gtktiledviewer: Wrap dialogs in a GtkScrolledWindow
Change-Id: I33be18779ea680f7a9c20814ca3c3d94d206900b
2016-09-23 18:30:10 +05:30
Aron Budea
451c7de9d7 tdf#102216: move row overflow check after EoF check (CSV import)
With the check in the original place, importing exactly
1048576 rows gave a warning.

Change-Id: Iae98c07f638168d8537436045423ae6274ef7f64
Reviewed-on: https://gerrit.libreoffice.org/29159
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
2016-09-23 12:35:59 +00:00
Samuel Mehrbrodt
949fa9a462 qadevOOo: Remove unused imports
Change-Id: I5295ba9af550d14f56f218765d43ce01a8177247
Reviewed-on: https://gerrit.libreoffice.org/29223
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23 12:29:42 +00:00
Samuel Mehrbrodt
065ef005e9 Make createDesktop return XDesktop, not Object
and adjust/cleanup calling instances

Change-Id: I6b7be34fe6fce0a6fdbf2227f3e565b2f434c88c
Reviewed-on: https://gerrit.libreoffice.org/29221
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23 12:25:52 +00:00
Caolán McNamara
01889962ca Resolves: tdf#99626 only the first queryTermination call in wizards works
cause the first call looks up the "queryTermination" method on the object
and replaces the object with that function, then calls on. Subsequent
calls then try to lookup "queryTermination" on "queryTermination".

Just pass queryTermination directly in the ctor (like all the other
wrappers do)

Change-Id: Ie042081c3c34e33b2f040d1ab1a33eeac4df9c3b
2016-09-23 13:11:57 +01:00
Caolán McNamara
7adb5c683c use std to impl this resource sharing
Change-Id: I41ea7bf672040089ccca5cf2bc449a0d0e78b903
Reviewed-on: https://gerrit.libreoffice.org/29219
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-23 12:09:02 +00:00
Jan-Marek Glogowski
04f50946de tdf#97721 KDE4 correct menu checkbox offset
Qt paints checkboxes next to images, so they always start left
oriented in menus.

Change-Id: I33ab0cf443f6716f9f9adc3ec2c394337db5f923
2016-09-23 13:19:02 +02:00
Stephan Bergmann
3ed5847c3e external/firebird: Use gb_Helper_extend_ld_path to add icu dir
Change-Id: If51813fc559a78a54ae5dcae4b8b9213c5e1bae6
Reviewed-on: https://gerrit.libreoffice.org/29215
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-09-23 11:15:05 +00:00
Samuel Mehrbrodt
b316edff1b Handle exception
Change-Id: If295d9a6106c0d03313c80464134e060da72bf53
Reviewed-on: https://gerrit.libreoffice.org/29224
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23 10:49:18 +00:00
Maarten Bosmans
4638436567 Factor out common ScInterpreter::GetInt32() code
This might also be slightly more efficient because for
GetInt32WithDefault() when the value is missing, the
default value is not converted to and from double anymore.

Change-Id: I0a234265273086824f749b04aba022dd5cef322f
Reviewed-on: https://gerrit.libreoffice.org/29203
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2016-09-23 10:36:35 +00:00
Michael Stahl
680b1b5976 liblangtag: stop whining about missing supplementalMetadata.xml
A good way to get developers to add files is to print 80 lines of
stack trace multiple times on startup.

Change-Id: Id563ab1d26d32e6fe3f14b2afb59949ea04f0d6a
2016-09-23 12:32:00 +02:00
Samuel Mehrbrodt
eb00cb1ba8 Remove duplicate comment
Change-Id: I78d207a4be9eeb9ddf1782ed2488c928d9d1744a
Reviewed-on: https://gerrit.libreoffice.org/29222
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-23 10:33:04 +00:00