2
0
mirror of https://github.com/openvswitch/ovs synced 2025-08-22 09:58:01 +00:00
ovs/ofproto/connmgr.c

2354 lines
74 KiB
C
Raw Normal View History

/*
* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2019 Nicira, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at:
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <config.h>
#include <errno.h>
#include <stdlib.h>
#include "bundles.h"
#include "connmgr.h"
#include "coverage.h"
#include "fail-open.h"
#include "in-band.h"
#include "odp-util.h"
#include "ofproto-provider.h"
#include "openvswitch/dynamic-string.h"
#include "openvswitch/ofp-actions.h"
#include "openvswitch/ofp-msgs.h"
#include "openvswitch/ofp-monitor.h"
#include "openvswitch/ofpbuf.h"
#include "openvswitch/vconn.h"
#include "openvswitch/vlog.h"
#include "ovs-atomic.h"
#include "pinsched.h"
#include "openvswitch/poll-loop.h"
#include "openvswitch/rconn.h"
#include "openvswitch/shash.h"
#include "sat-math.h"
#include "simap.h"
#include "stream.h"
#include "timeval.h"
#include "util.h"
VLOG_DEFINE_THIS_MODULE(connmgr);
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 5);
/* An OpenFlow connection.
*
*
* Thread-safety
* =============
*
* 'ofproto_mutex' must be held whenever an ofconn is created or destroyed or,
* more or less equivalently, whenever an ofconn is added to or removed from a
* connmgr. 'ofproto_mutex' doesn't protect the data inside the ofconn, except
* as specifically noted below. */
struct ofconn {
struct connmgr *connmgr; /* Connection's manager. */
struct ovs_list connmgr_node; /* In connmgr->conns. */
struct ofservice *ofservice; /* Connection's service. */
struct ovs_list ofservice_node; /* In service->conns. */
struct rconn *rconn; /* OpenFlow connection. */
enum ofconn_type type; /* Type. */
enum ofproto_band band; /* In-band or out-of-band? */
bool want_packet_in_on_miss;
/* OpenFlow state. */
enum ofp12_controller_role role; /* Role. */
enum ofputil_protocol protocol; /* Current protocol variant. */
enum ofputil_packet_in_format packet_in_format;
/* OFPT_PACKET_IN related data. */
int packet_in_queue_size;
struct rconn_packet_counter *packet_in_counter; /* # queued on 'rconn'. */
#define N_SCHEDULERS 2
struct pinsched *schedulers[N_SCHEDULERS];
int miss_send_len; /* Bytes to send of buffered packets. */
uint16_t controller_id; /* Connection controller ID. */
/* Number of OpenFlow messages queued on 'rconn' as replies to OpenFlow
* requests, and the maximum number before we stop reading OpenFlow
* requests. */
#define OFCONN_REPLY_MAX 100
struct rconn_packet_counter *reply_counter;
/* Asynchronous message configuration in each possible role.
*
* A 1-bit enables sending an asynchronous message for one possible reason
* that the message might be generated, a 0-bit disables it. */
struct ofputil_async_cfg *async_cfg;
/* Flow table operation logging. */
int n_add, n_delete, n_modify; /* Number of unreported ops of each kind. */
long long int first_op, last_op; /* Range of times for unreported ops. */
long long int next_op_report; /* Time to report ops, or LLONG_MAX. */
long long int op_backoff; /* Earliest time to report ops again. */
/* Reassembly of multipart requests. */
struct hmap assembler;
/* Flow monitors (e.g. NXST_FLOW_MONITOR). */
/* Configuration. Contains "struct ofmonitor"s. */
struct hmap monitors OVS_GUARDED_BY(ofproto_mutex);
/* Flow control.
*
* When too many flow monitor notifications back up in the transmit buffer,
* we pause the transmission of further notifications. These members track
* the flow control state.
*
* When notifications are flowing, 'monitor_paused' is 0. When
* notifications are paused, 'monitor_paused' is the value of
* 'monitor_seqno' at the point we paused.
*
* 'monitor_counter' counts the OpenFlow messages and bytes currently in
* flight. This value growing too large triggers pausing. */
uint64_t monitor_paused OVS_GUARDED_BY(ofproto_mutex);
struct rconn_packet_counter *monitor_counter OVS_GUARDED_BY(ofproto_mutex);
/* State of monitors for a single ongoing flow_mod.
*
* 'updates' is a list of "struct ofpbuf"s that contain
* NXST_FLOW_MONITOR_REPLY messages representing the changes made by the
* current flow_mod.
*
* When 'updates' is nonempty, 'sent_abbrev_update' is true if 'updates'
* contains an update event of type NXFME_ABBREV and false otherwise.. */
struct ovs_list updates OVS_GUARDED_BY(ofproto_mutex);
bool sent_abbrev_update OVS_GUARDED_BY(ofproto_mutex);
/* Active bundles. Contains "struct ofp_bundle"s. */
struct hmap bundles;
long long int next_bundle_expiry_check;
};
/* vswitchd/ovs-vswitchd.8.in documents the value of BUNDLE_IDLE_LIFETIME in
* seconds. That documentation must be kept in sync with the value below. */
#define BUNDLE_EXPIRY_INTERVAL 1000 /* Check bundle expiry every 1 sec. */
#define BUNDLE_IDLE_TIMEOUT_DEFAULT 10000 /* Expire idle bundles after
* 10 seconds. */
static unsigned int bundle_idle_timeout = BUNDLE_IDLE_TIMEOUT_DEFAULT;
static void ofconn_create(struct ofservice *, struct rconn *,
const struct ofproto_controller *settings)
OVS_EXCLUDED(ofproto_mutex);
static void ofconn_destroy(struct ofconn *) OVS_REQUIRES(ofproto_mutex);
static void ofconn_reconfigure(struct ofconn *,
const struct ofproto_controller *);
static void ofconn_run(struct ofconn *,
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
void (*handle_openflow)(struct ofconn *,
const struct ovs_list *msgs));
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
static void ofconn_wait(struct ofconn *);
static void ofconn_log_flow_mods(struct ofconn *);
static char *ofconn_make_name(const struct connmgr *, const char *target);
static void ofconn_set_rate_limit(struct ofconn *, int rate, int burst);
static void ofconn_send(const struct ofconn *, struct ofpbuf *,
struct rconn_packet_counter *);
static void do_send_packet_ins(struct ofconn *, struct ovs_list *txq);
/* A listener for incoming OpenFlow connections or for establishing an
* outgoing connection. */
struct ofservice {
struct hmap_node hmap_node; /* In connmgr->services, by target. */
struct connmgr *connmgr;
char *target; /* e.g. "tcp:..." or "pssl:...". */
struct ovs_list conns; /* "ofconn"s generated by this service. */
enum ofconn_type type; /* OFCONN_PRIMARY or OFCONN_SERVICE. */
/* Source of connections. */
struct rconn *rconn; /* Active connection only. */
struct pvconn *pvconn; /* Passive listener only. */
/* Settings for "struct ofconn"s established by this service. */
struct ofproto_controller s;
};
static void ofservice_run(struct ofservice *);
static void ofservice_wait(struct ofservice *);
static int ofservice_reconfigure(struct ofservice *,
const struct ofproto_controller *)
OVS_REQUIRES(ofproto_mutex);
static void ofservice_create(struct connmgr *mgr, const char *target,
const struct ofproto_controller *)
OVS_REQUIRES(ofproto_mutex);
static void ofservice_destroy(struct ofservice *) OVS_REQUIRES(ofproto_mutex);
static struct ofservice *ofservice_lookup(struct connmgr *,
const char *target);
/* Connection manager for an OpenFlow switch. */
struct connmgr {
struct ofproto *ofproto;
char *name;
char *local_port_name;
/* OpenFlow connections.
*
* All modifications to 'conns' protected by ofproto_mutex, so that any
* traversals from other threads can be made safe by holding the
* ofproto_mutex.*/
struct ovs_list conns; /* All ofconns. */
uint64_t primary_election_id; /* monotonically increasing sequence number
* for primary election */
bool primary_election_id_defined;
/* OpenFlow connection establishment. */
struct hmap services; /* Contains "struct ofservice"s. */
struct pvconn **snoops;
size_t n_snoops;
/* Fail open. */
struct fail_open *fail_open;
enum ofproto_fail_mode fail_mode;
/* In-band control. */
struct in_band *in_band;
struct sockaddr_in *extra_in_band_remotes;
size_t n_extra_remotes;
int in_band_queue;
ATOMIC(int) want_packet_in_on_miss; /* Sum of ofconns' values. */
};
static void update_in_band_remotes(struct connmgr *);
static void add_snooper(struct connmgr *, struct vconn *);
static void ofmonitor_run(struct connmgr *);
static void ofmonitor_wait(struct connmgr *);
/* Creates and returns a new connection manager owned by 'ofproto'. 'name' is
* a name for the ofproto suitable for using in log messages.
* 'local_port_name' is the name of the local port (OFPP_LOCAL) within
* 'ofproto'. */
struct connmgr *
connmgr_create(struct ofproto *ofproto,
const char *name, const char *local_port_name)
{
struct connmgr *mgr = xmalloc(sizeof *mgr);
mgr->ofproto = ofproto;
mgr->name = xstrdup(name);
mgr->local_port_name = xstrdup(local_port_name);
ovs_list_init(&mgr->conns);
mgr->primary_election_id = 0;
mgr->primary_election_id_defined = false;
hmap_init(&mgr->services);
mgr->snoops = NULL;
mgr->n_snoops = 0;
mgr->fail_open = NULL;
mgr->fail_mode = OFPROTO_FAIL_SECURE;
mgr->in_band = NULL;
mgr->extra_in_band_remotes = NULL;
mgr->n_extra_remotes = 0;
mgr->in_band_queue = -1;
atomic_init(&mgr->want_packet_in_on_miss, 0);
return mgr;
}
/* The default "table-miss" behaviour for OpenFlow1.3+ is to drop the
* packet rather than to send the packet to the controller.
*
* This function maintains the count of pre-OpenFlow1.3 with controller_id 0,
* as we assume these are the controllers that should receive "table-miss"
* notifications. */
static void
update_want_packet_in_on_miss(struct ofconn *ofconn)
{
/* We want a packet-in on miss when controller_id is zero and OpenFlow is
* lower than version 1.3. */
enum ofputil_protocol p = ofconn->protocol;
int new_want = (ofconn->controller_id == 0 &&
(p == OFPUTIL_P_NONE ||
ofputil_protocol_to_ofp_version(p) < OFP13_VERSION));
/* Update the setting and the count if necessary. */
int old_want = ofconn->want_packet_in_on_miss;
if (old_want != new_want) {
atomic_int *dst = &ofconn->connmgr->want_packet_in_on_miss;
int count;
atomic_read_relaxed(dst, &count);
atomic_store_relaxed(dst, count - old_want + new_want);
ofconn->want_packet_in_on_miss = new_want;
}
}
/* Frees 'mgr' and all of its resources. */
void
connmgr_destroy(struct connmgr *mgr)
OVS_REQUIRES(ofproto_mutex)
{
if (!mgr) {
return;
}
struct ofservice *ofservice;
HMAP_FOR_EACH_SAFE (ofservice, hmap_node, &mgr->services) {
ofservice_destroy(ofservice);
}
hmap_destroy(&mgr->services);
ovs_assert(ovs_list_is_empty(&mgr->conns));
for (size_t i = 0; i < mgr->n_snoops; i++) {
pvconn_close(mgr->snoops[i]);
}
free(mgr->snoops);
fail_open_destroy(mgr->fail_open);
mgr->fail_open = NULL;
in_band_destroy(mgr->in_band);
mgr->in_band = NULL;
free(mgr->extra_in_band_remotes);
free(mgr->name);
free(mgr->local_port_name);
free(mgr);
}
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
/* Does all of the periodic maintenance required by 'mgr'. Calls
* 'handle_openflow' for each message received on an OpenFlow connection,
* passing along the OpenFlow connection itself and the message that was sent.
* 'handle_openflow' must not modify or free the message. */
void
connmgr_run(struct connmgr *mgr,
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
void (*handle_openflow)(struct ofconn *,
const struct ovs_list *msgs))
OVS_EXCLUDED(ofproto_mutex)
{
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
if (mgr->in_band) {
if (!in_band_run(mgr->in_band)) {
in_band_destroy(mgr->in_band);
mgr->in_band = NULL;
}
}
struct ofconn *ofconn;
LIST_FOR_EACH_SAFE (ofconn, connmgr_node, &mgr->conns) {
ofconn_run(ofconn, handle_openflow);
}
ofmonitor_run(mgr);
/* Fail-open maintenance. Do this after processing the ofconns since
* fail-open checks the status of the controller rconn. */
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
if (mgr->fail_open) {
fail_open_run(mgr->fail_open);
}
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
ofservice_run(ofservice);
}
for (size_t i = 0; i < mgr->n_snoops; i++) {
struct vconn *vconn;
int retval = pvconn_accept(mgr->snoops[i], &vconn);
if (!retval) {
add_snooper(mgr, vconn);
} else if (retval != EAGAIN) {
VLOG_WARN_RL(&rl, "accept failed (%s)", ovs_strerror(retval));
}
}
}
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
/* Causes the poll loop to wake up when connmgr_run() needs to run. */
void
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
connmgr_wait(struct connmgr *mgr)
{
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
ofconn_wait(ofconn);
}
ofmonitor_wait(mgr);
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
if (mgr->in_band) {
in_band_wait(mgr->in_band);
}
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
if (mgr->fail_open) {
fail_open_wait(mgr->fail_open);
}
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
ofservice_wait(ofservice);
}
for (size_t i = 0; i < mgr->n_snoops; i++) {
pvconn_wait(mgr->snoops[i]);
}
}
/* Adds some memory usage statistics for 'mgr' into 'usage', for use with
* memory_report(). */
void
connmgr_get_memory_usage(const struct connmgr *mgr, struct simap *usage)
{
unsigned int packets = 0;
unsigned int ofconns = 0;
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
ofconns++;
packets += rconn_count_txqlen(ofconn->rconn);
for (int i = 0; i < N_SCHEDULERS; i++) {
struct pinsched_stats stats;
pinsched_get_stats(ofconn->schedulers[i], &stats);
packets += stats.n_queued;
}
}
simap_increase(usage, "ofconns", ofconns);
simap_increase(usage, "packets", packets);
}
/* Returns the ofproto that owns 'ofconn''s connmgr. */
struct ofproto *
ofconn_get_ofproto(const struct ofconn *ofconn)
{
return ofconn->connmgr->ofproto;
}
/* Sets the bundle idle timeout to 'timeout' seconds, interpreting 0 as
* requesting the default timeout.
*
* The OpenFlow spec mandates the timeout to be at least one second; . */
void
connmgr_set_bundle_idle_timeout(unsigned timeout)
{
bundle_idle_timeout = (timeout
? sat_mul(timeout, 1000)
: BUNDLE_IDLE_TIMEOUT_DEFAULT);
}
/* OpenFlow configuration. */
static void update_fail_open(struct connmgr *) OVS_EXCLUDED(ofproto_mutex);
static int set_pvconns(struct pvconn ***pvconnsp, size_t *n_pvconnsp,
const struct sset *);
/* Returns true if 'mgr' has any configured primary controllers.
*
* Service controllers do not count, but configured primary controllers do
* count whether or not they are currently connected. */
bool
connmgr_has_controllers(const struct connmgr *mgr)
{
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
if (ofservice->type == OFCONN_PRIMARY) {
return true;
}
}
return false;
}
static struct ofconn *
ofservice_first_conn(const struct ofservice *ofservice)
{
return (ovs_list_is_empty(&ofservice->conns)
? NULL
: CONTAINER_OF(ofservice->conns.next,
struct ofconn, ofservice_node));
}
/* Initializes 'info' and populates it with information about each configured
* primary controller. The keys in 'info' are the controllers' targets; the
* data values are corresponding "struct ofproto_controller_info".
*
* The caller owns 'info' and everything in it and should free it when it is no
* longer needed. */
void
connmgr_get_controller_info(struct connmgr *mgr, struct shash *info)
{
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
const struct rconn *rconn = ofservice->rconn;
if (!rconn) {
continue;
}
const char *target = rconn_get_target(rconn);
if (!shash_find(info, target)) {
struct ofconn *ofconn = ofservice_first_conn(ofservice);
struct ofproto_controller_info *cinfo = xmalloc(sizeof *cinfo);
long long int now = time_msec();
long long int last_connection = rconn_get_last_connection(rconn);
long long int last_disconnect = rconn_get_last_disconnect(rconn);
int last_error = rconn_get_last_error(rconn);
int i;
shash_add(info, target, cinfo);
cinfo->is_connected = rconn_is_connected(rconn);
cinfo->role = ofconn ? ofconn->role : OFPCR12_ROLE_NOCHANGE;
smap_init(&cinfo->pairs);
if (last_error) {
smap_add(&cinfo->pairs, "last_error",
ovs_retval_to_string(last_error));
}
smap_add(&cinfo->pairs, "state", rconn_get_state(rconn));
if (last_connection != LLONG_MIN) {
smap_add_format(&cinfo->pairs, "sec_since_connect",
"%lld", (now - last_connection) / 1000);
}
if (last_disconnect != LLONG_MIN) {
smap_add_format(&cinfo->pairs, "sec_since_disconnect",
"%lld", (now - last_disconnect) / 1000);
}
for (i = 0; i < N_SCHEDULERS; i++) {
if (ofconn && ofconn->schedulers[i]) {
const char *name = i ? "miss" : "action";
struct pinsched_stats stats;
pinsched_get_stats(ofconn->schedulers[i], &stats);
smap_add_nocopy(&cinfo->pairs,
xasprintf("packet-in-%s-backlog", name),
xasprintf("%u", stats.n_queued));
smap_add_nocopy(&cinfo->pairs,
xasprintf("packet-in-%s-bypassed", name),
xasprintf("%llu", stats.n_normal));
smap_add_nocopy(&cinfo->pairs,
xasprintf("packet-in-%s-queued", name),
xasprintf("%llu", stats.n_limited));
smap_add_nocopy(&cinfo->pairs,
xasprintf("packet-in-%s-dropped", name),
xasprintf("%llu", stats.n_queue_dropped));
}
}
}
}
}
void
connmgr_free_controller_info(struct shash *info)
{
struct shash_node *node;
SHASH_FOR_EACH (node, info) {
struct ofproto_controller_info *cinfo = node->data;
smap_destroy(&cinfo->pairs);
free(cinfo);
}
shash_destroy(info);
}
/* Changes 'mgr''s set of controllers to the 'n_controllers' controllers in
* 'controllers'. */
void
connmgr_set_controllers(struct connmgr *mgr, struct shash *controllers)
OVS_EXCLUDED(ofproto_mutex)
{
bool had_controllers = connmgr_has_controllers(mgr);
/* Required to add and remove ofconns. This could probably be narrowed to
* cover a smaller amount of code, if that yielded some benefit. */
ovs_mutex_lock(&ofproto_mutex);
/* Create newly configured services. */
struct shash_node *node;
SHASH_FOR_EACH (node, controllers) {
const char *target = node->name;
const struct ofproto_controller *c = node->data;
if (!ofservice_lookup(mgr, target)) {
ofservice_create(mgr, target, c);
}
}
/* Delete services that are no longer configured.
* Update configuration of all now-existing services. */
struct ofservice *ofservice;
HMAP_FOR_EACH_SAFE (ofservice, hmap_node, &mgr->services) {
const char *target = ofservice->target;
struct ofproto_controller *c = shash_find_data(controllers, target);
if (!c) {
VLOG_INFO("%s: removed %s controller \"%s\"",
mgr->name, ofconn_type_to_string(ofservice->type),
target);
ofservice_destroy(ofservice);
} else {
if (ofservice_reconfigure(ofservice, c)) {
char *target_to_restore = xstrdup(target);
VLOG_INFO("%s: Changes to controller \"%s\" "
"expects re-initialization: Re-initializing now.",
mgr->name, target);
ofservice_destroy(ofservice);
ofservice_create(mgr, target_to_restore, c);
free(target_to_restore);
}
}
}
ovs_mutex_unlock(&ofproto_mutex);
update_in_band_remotes(mgr);
update_fail_open(mgr);
if (had_controllers != connmgr_has_controllers(mgr)) {
ofproto_flush_flows(mgr->ofproto);
}
}
/* Drops the connections between 'mgr' and all of its primary and secondary
* controllers, forcing them to reconnect. */
void
connmgr_reconnect(const struct connmgr *mgr)
{
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
rconn_reconnect(ofconn->rconn);
}
}
/* Sets the "snoops" for 'mgr' to the pvconn targets listed in 'snoops'.
*
* A "snoop" is a pvconn to which every OpenFlow message to or from the most
* important controller on 'mgr' is mirrored. */
int
connmgr_set_snoops(struct connmgr *mgr, const struct sset *snoops)
{
return set_pvconns(&mgr->snoops, &mgr->n_snoops, snoops);
}
/* Adds each of the snoops currently configured on 'mgr' to 'snoops'. */
void
connmgr_get_snoops(const struct connmgr *mgr, struct sset *snoops)
{
for (size_t i = 0; i < mgr->n_snoops; i++) {
sset_add(snoops, pvconn_get_name(mgr->snoops[i]));
}
}
/* Returns true if 'mgr' has at least one snoop, false if it has none. */
bool
connmgr_has_snoops(const struct connmgr *mgr)
{
return mgr->n_snoops > 0;
}
static void
update_in_band_remotes(struct connmgr *mgr)
{
/* Allocate enough memory for as many remotes as we could possibly have. */
size_t max_addrs = mgr->n_extra_remotes + hmap_count(&mgr->services);
struct sockaddr_in *addrs = xmalloc(max_addrs * sizeof *addrs);
size_t n_addrs = 0;
/* Add all the remotes. */
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
const char *target = ofservice->target;
union {
struct sockaddr_storage ss;
struct sockaddr_in in;
} sa;
if (ofservice->s.band == OFPROTO_IN_BAND
&& stream_parse_target_with_default_port(target, OFP_PORT, &sa.ss)
&& sa.ss.ss_family == AF_INET) {
addrs[n_addrs++] = sa.in;
}
}
for (size_t i = 0; i < mgr->n_extra_remotes; i++) {
addrs[n_addrs++] = mgr->extra_in_band_remotes[i];
}
/* Create or update or destroy in-band. */
if (n_addrs) {
if (!mgr->in_band) {
in_band_create(mgr->ofproto, mgr->local_port_name, &mgr->in_band);
}
} else {
/* in_band_run() needs a chance to delete any existing in-band flows.
* We will destroy mgr->in_band after it's done with that. */
}
if (mgr->in_band) {
in_band_set_queue(mgr->in_band, mgr->in_band_queue);
in_band_set_remotes(mgr->in_band, addrs, n_addrs);
}
/* Clean up. */
free(addrs);
}
static void
update_fail_open(struct connmgr *mgr)
OVS_EXCLUDED(ofproto_mutex)
{
if (connmgr_has_controllers(mgr)
&& mgr->fail_mode == OFPROTO_FAIL_STANDALONE) {
if (!mgr->fail_open) {
mgr->fail_open = fail_open_create(mgr->ofproto, mgr);
}
} else {
ovs_mutex_lock(&ofproto_mutex);
fail_open_destroy(mgr->fail_open);
ovs_mutex_unlock(&ofproto_mutex);
mgr->fail_open = NULL;
}
}
static int
set_pvconns(struct pvconn ***pvconnsp, size_t *n_pvconnsp,
const struct sset *sset)
{
/* Free the old pvconns. */
struct pvconn **old_pvconns = *pvconnsp;
size_t old_n_pvconns = *n_pvconnsp;
for (size_t i = 0; i < old_n_pvconns; i++) {
pvconn_close(old_pvconns[i]);
}
free(old_pvconns);
/* Populate the new pvconns. */
struct pvconn **new_pvconns = xmalloc(sset_count(sset)
* sizeof *new_pvconns);
size_t new_n_pvconns = 0;
int retval = 0;
const char *name;
SSET_FOR_EACH (name, sset) {
struct pvconn *pvconn;
int error = pvconn_open(name, 0, 0, &pvconn);
if (!error) {
new_pvconns[new_n_pvconns++] = pvconn;
} else {
VLOG_ERR("failed to listen on %s: %s", name, ovs_strerror(error));
if (!retval) {
retval = error;
}
}
}
*pvconnsp = new_pvconns;
*n_pvconnsp = new_n_pvconns;
return retval;
}
/* Returns a "preference level" for snooping 'ofconn'. A higher return value
* means that 'ofconn' is more interesting for monitoring than a lower return
* value. */
static int
snoop_preference(const struct ofservice *ofservice)
{
struct ofconn *ofconn = ofservice_first_conn(ofservice);
if (!ofconn) {
return 0;
}
switch (ofconn->role) {
case OFPCR12_ROLE_PRIMARY:
return 3;
case OFPCR12_ROLE_EQUAL:
return 2;
case OFPCR12_ROLE_SECONDARY:
return 1;
case OFPCR12_ROLE_NOCHANGE:
default:
/* Shouldn't happen. */
return 0;
}
}
/* One of 'mgr''s "snoop" pvconns has accepted a new connection on 'vconn'.
* Connects this vconn to a controller. */
static void
add_snooper(struct connmgr *mgr, struct vconn *vconn)
{
/* Pick a controller for monitoring. */
struct ofservice *best = NULL;
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
if (ofservice->rconn &&
(!best || snoop_preference(ofservice) > snoop_preference(best))) {
best = ofservice;
}
}
if (best) {
rconn_add_monitor(best->rconn, vconn);
} else {
VLOG_INFO_RL(&rl, "no controller connection to snoop");
vconn_close(vconn);
}
}
/* Public ofconn functions. */
/* Returns the connection type, either OFCONN_PRIMARY or OFCONN_SERVICE. */
enum ofconn_type
ofconn_get_type(const struct ofconn *ofconn)
{
return ofconn->type;
}
/* If a primary election id is defined, stores it into '*idp' and returns
* true. Otherwise, stores UINT64_MAX into '*idp' and returns false. */
bool
ofconn_get_primary_election_id(const struct ofconn *ofconn, uint64_t *idp)
{
*idp = (ofconn->connmgr->primary_election_id_defined
? ofconn->connmgr->primary_election_id
: UINT64_MAX);
return ofconn->connmgr->primary_election_id_defined;
}
/* Sets the primary election id.
*
* Returns true if successful, false if the id is stale
*/
bool
ofconn_set_primary_election_id(struct ofconn *ofconn, uint64_t id)
{
if (ofconn->connmgr->primary_election_id_defined
&&
/* Unsigned difference interpreted as a two's complement signed
* value */
(int64_t)(id - ofconn->connmgr->primary_election_id) < 0) {
return false;
}
ofconn->connmgr->primary_election_id = id;
ofconn->connmgr->primary_election_id_defined = true;
return true;
}
/* Returns the role configured for 'ofconn'.
*
* The default role, if no other role has been set, is OFPCR12_ROLE_EQUAL. */
enum ofp12_controller_role
ofconn_get_role(const struct ofconn *ofconn)
{
return ofconn->role;
}
void
ofconn_send_role_status(struct ofconn *ofconn, uint32_t role, uint8_t reason)
{
struct ofputil_role_status status;
status.reason = reason;
status.role = role;
ofconn_get_primary_election_id(ofconn, &status.generation_id);
struct ofpbuf *buf
= ofputil_encode_role_status(&status, ofconn_get_protocol(ofconn));
if (buf) {
ofconn_send(ofconn, buf, NULL);
}
}
/* Changes 'ofconn''s role to 'role'. If 'role' is OFPCR12_ROLE_PRIMARY then
* any existing primary is demoted to a secondary. */
void
ofconn_set_role(struct ofconn *ofconn, enum ofp12_controller_role role)
{
if (role != ofconn->role && role == OFPCR12_ROLE_PRIMARY) {
struct ofconn *other;
LIST_FOR_EACH (other, connmgr_node, &ofconn->connmgr->conns) {
if (other->role == OFPCR12_ROLE_PRIMARY) {
other->role = OFPCR12_ROLE_SECONDARY;
ofconn_send_role_status(other, OFPCR12_ROLE_SECONDARY,
OFPCRR_PRIMARY_REQUEST);
}
}
}
ofconn->role = role;
}
void
ofconn_set_invalid_ttl_to_controller(struct ofconn *ofconn, bool enable)
{
struct ofputil_async_cfg ac = ofconn_get_async_config(ofconn);
uint32_t bit = 1u << OFPR_INVALID_TTL;
if (enable) {
ac.primary[OAM_PACKET_IN] |= bit;
} else {
ac.primary[OAM_PACKET_IN] &= ~bit;
}
ofconn_set_async_config(ofconn, &ac);
}
bool
ofconn_get_invalid_ttl_to_controller(struct ofconn *ofconn)
{
struct ofputil_async_cfg ac = ofconn_get_async_config(ofconn);
uint32_t bit = 1u << OFPR_INVALID_TTL;
return (ac.primary[OAM_PACKET_IN] & bit) != 0;
}
/* Returns the currently configured protocol for 'ofconn', one of OFPUTIL_P_*.
*
* Returns OFPUTIL_P_NONE, which is not a valid protocol, if 'ofconn' hasn't
* completed version negotiation. This can't happen if at least one OpenFlow
* message, other than OFPT_HELLO, has been received on the connection (such as
* in ofproto.c's message handling code), since version negotiation is a
* prerequisite for starting to receive messages. This means that
* OFPUTIL_P_NONE is a special case that most callers need not worry about. */
enum ofputil_protocol
ofconn_get_protocol(const struct ofconn *ofconn)
{
if (ofconn->protocol == OFPUTIL_P_NONE &&
rconn_is_connected(ofconn->rconn)) {
int version = rconn_get_version(ofconn->rconn);
if (version > 0) {
ofconn_set_protocol(CONST_CAST(struct ofconn *, ofconn),
ofputil_protocol_from_ofp_version(version));
}
}
return ofconn->protocol;
}
/* Sets the protocol for 'ofconn' to 'protocol' (one of OFPUTIL_P_*).
*
* (This doesn't actually send anything to accomplish this. Presumably the
* caller already did that.) */
void
ofconn_set_protocol(struct ofconn *ofconn, enum ofputil_protocol protocol)
{
ofconn->protocol = protocol;
update_want_packet_in_on_miss(ofconn);
}
/* Returns the currently configured packet in format for 'ofconn', one of
* NXPIF_*.
*
* The default, if no other format has been set, is NXPIF_STANDARD. */
enum ofputil_packet_in_format
ofconn_get_packet_in_format(struct ofconn *ofconn)
{
return ofconn->packet_in_format;
}
/* Sets the packet in format for 'ofconn' to 'packet_in_format' (one of
* NXPIF_*). */
void
ofconn_set_packet_in_format(struct ofconn *ofconn,
enum ofputil_packet_in_format packet_in_format)
{
ofconn->packet_in_format = packet_in_format;
}
/* Sets the controller connection ID for 'ofconn' to 'controller_id'.
*
* The connection controller ID is used for OFPP_CONTROLLER and
* NXAST_CONTROLLER actions. See "struct nx_action_controller" for details. */
void
ofconn_set_controller_id(struct ofconn *ofconn, uint16_t controller_id)
{
ofconn->controller_id = controller_id;
update_want_packet_in_on_miss(ofconn);
}
/* Returns the default miss send length for 'ofconn'. */
int
ofconn_get_miss_send_len(const struct ofconn *ofconn)
{
return ofconn->miss_send_len;
}
/* Sets the default miss send length for 'ofconn' to 'miss_send_len'. */
void
ofconn_set_miss_send_len(struct ofconn *ofconn, int miss_send_len)
{
ofconn->miss_send_len = miss_send_len;
}
void
ofconn_set_async_config(struct ofconn *ofconn,
const struct ofputil_async_cfg *ac)
{
if (!ofconn->async_cfg) {
ofconn->async_cfg = xmalloc(sizeof *ofconn->async_cfg);
}
*ofconn->async_cfg = *ac;
if (ofputil_protocol_to_ofp_version(ofconn_get_protocol(ofconn))
< OFP14_VERSION) {
if (ofconn->async_cfg->primary[OAM_PACKET_IN] & (1u << OFPR_ACTION)) {
ofconn->async_cfg->primary[OAM_PACKET_IN] |= OFPR14_ACTION_BITS;
}
if (ofconn->async_cfg->secondary[OAM_PACKET_IN] & (1u << OFPR_ACTION)) {
ofconn->async_cfg->secondary[OAM_PACKET_IN] |= OFPR14_ACTION_BITS;
}
}
}
struct ofputil_async_cfg
ofconn_get_async_config(const struct ofconn *ofconn)
{
if (ofconn->async_cfg) {
return *ofconn->async_cfg;
}
int version = rconn_get_version(ofconn->rconn);
return (version < 0 || !ofconn->ofservice->s.enable_async_msgs
? OFPUTIL_ASYNC_CFG_INIT
: ofputil_async_cfg_default(version));
}
/* Sends 'msg' on 'ofconn', accounting it as a reply. (If there is a
* sufficient number of OpenFlow replies in-flight on a single ofconn, then the
* connmgr will stop accepting new OpenFlow requests on that ofconn until the
* controller has accepted some of the replies.) */
void
ofconn_send_reply(const struct ofconn *ofconn, struct ofpbuf *msg)
{
ofconn_send(ofconn, msg, ofconn->reply_counter);
}
/* Sends each of the messages in list 'replies' on 'ofconn' in order,
* accounting them as replies. */
void
ofconn_send_replies(const struct ofconn *ofconn, struct ovs_list *replies)
{
struct ofpbuf *reply;
LIST_FOR_EACH_POP (reply, list_node, replies) {
ofconn_send_reply(ofconn, reply);
}
}
/* Sends 'error' on 'ofconn', as a reply to 'request'. */
void
ofconn_send_error(const struct ofconn *ofconn,
const struct ofp_header *request, enum ofperr error)
{
static struct vlog_rate_limit err_rl = VLOG_RATE_LIMIT_INIT(10, 10);
struct ofpbuf *reply = ofperr_encode_reply(error, request);
if (!VLOG_DROP_INFO(&err_rl)) {
size_t request_len = ntohs(request->length);
enum ofpraw raw;
const char *type_name = (!ofpraw_decode_partial(&raw, request,
MIN(64, request_len))
? ofpraw_get_name(raw)
: "invalid");
VLOG_INFO("%s: sending %s error reply to %s message",
rconn_get_name(ofconn->rconn), ofperr_to_string(error),
type_name);
}
ofconn_send_reply(ofconn, reply);
}
/* Reports that a flow_mod operation of the type specified by 'command' was
* successfully executed by 'ofconn', so that the connmgr can log it. */
void
ofconn_report_flow_mod(struct ofconn *ofconn,
enum ofp_flow_mod_command command)
{
switch (command) {
case OFPFC_ADD:
ofconn->n_add++;
break;
case OFPFC_MODIFY:
case OFPFC_MODIFY_STRICT:
ofconn->n_modify++;
break;
case OFPFC_DELETE:
case OFPFC_DELETE_STRICT:
ofconn->n_delete++;
break;
}
long long int now = time_msec();
if (ofconn->next_op_report == LLONG_MAX) {
ofconn->first_op = now;
ofconn->next_op_report = MAX(now + 10 * 1000, ofconn->op_backoff);
ofconn->op_backoff = ofconn->next_op_report + 60 * 1000;
}
ofconn->last_op = now;
}
/* OpenFlow 1.4 bundles. */
static inline uint32_t
bundle_hash(uint32_t id)
{
return hash_int(id, 0);
}
struct ofp_bundle *
ofconn_get_bundle(struct ofconn *ofconn, uint32_t id)
{
struct ofp_bundle *bundle;
HMAP_FOR_EACH_IN_BUCKET(bundle, node, bundle_hash(id), &ofconn->bundles) {
if (bundle->id == id) {
return bundle;
}
}
return NULL;
}
void
ofconn_insert_bundle(struct ofconn *ofconn, struct ofp_bundle *bundle)
{
hmap_insert(&ofconn->bundles, &bundle->node, bundle_hash(bundle->id));
}
void
ofconn_remove_bundle(struct ofconn *ofconn, struct ofp_bundle *bundle)
{
hmap_remove(&ofconn->bundles, &bundle->node);
}
static void
bundle_remove_all(struct ofconn *ofconn)
{
struct ofp_bundle *b;
HMAP_FOR_EACH_SAFE (b, node, &ofconn->bundles) {
ofp_bundle_remove__(ofconn, b);
}
}
static void
bundle_remove_expired(struct ofconn *ofconn, long long int now)
{
long long int limit = now - bundle_idle_timeout;
struct ofp_bundle *b;
HMAP_FOR_EACH_SAFE (b, node, &ofconn->bundles) {
if (b->used <= limit) {
ofconn_send_error(ofconn, b->msg, OFPERR_OFPBFC_TIMEOUT);
ofp_bundle_remove__(ofconn, b);
}
}
}
/* Private ofconn functions. */
static void
ofconn_create(struct ofservice *ofservice, struct rconn *rconn,
const struct ofproto_controller *settings)
OVS_EXCLUDED(ofproto_mutex)
{
ovs_mutex_lock(&ofproto_mutex);
struct ofconn *ofconn = xzalloc(sizeof *ofconn);
ofconn->connmgr = ofservice->connmgr;
ovs_list_push_back(&ofservice->connmgr->conns, &ofconn->connmgr_node);
hmap_init(&ofconn->assembler);
ofconn->ofservice = ofservice;
ovs_list_push_back(&ofservice->conns, &ofconn->ofservice_node);
ofconn->rconn = rconn;
ofconn->type = settings->type;
ofconn->band = settings->band;
ofconn->role = OFPCR12_ROLE_EQUAL;
ofconn_set_protocol(ofconn, OFPUTIL_P_NONE);
ofconn->packet_in_format = OFPUTIL_PACKET_IN_STD;
ofconn->packet_in_queue_size = settings->max_pktq_size;
ofconn->packet_in_counter = rconn_packet_counter_create();
ofconn->miss_send_len = (ofconn->type == OFCONN_PRIMARY
? OFP_DEFAULT_MISS_SEND_LEN
: 0);
ofconn->controller_id = 0;
ofconn->reply_counter = rconn_packet_counter_create();
ofconn->async_cfg = NULL;
ofconn->n_add = ofconn->n_delete = ofconn->n_modify = 0;
ofconn->first_op = ofconn->last_op = LLONG_MIN;
ofconn->next_op_report = LLONG_MAX;
ofconn->op_backoff = LLONG_MIN;
hmap_init(&ofconn->monitors);
ofconn->monitor_counter = rconn_packet_counter_create();
ovs_list_init(&ofconn->updates);
hmap_init(&ofconn->bundles);
ofconn->next_bundle_expiry_check = time_msec() + BUNDLE_EXPIRY_INTERVAL;
connmgr: Fix ofconn configuration on vswitchd startup. ofconn connection parameters, such as probe_interval and max_backoff, are always set to their default values when vswitchd starts up even if the user has configured these to be something different in ovsdb: $ ovs-vsctl set controller UUID inactivity_probe=9000 $ journalctl -u ovs-vswitchd.service | grep "inactivity" ovs|10895|rconn|DBG|dp1<->tcp:127.0.0.1:6653: idle 9 seconds, sending inactivity probe $ systemctl restart openvswitch-switch.service $ journalctl -u ovs-vswitchd.service | grep "inactivity" ovs|00848|rconn|DBG|dp1<->tcp:127.0.0.1:6653: idle 5 seconds, sending inactivity probe This bug was introduced by commit a0baa7df (connmgr: Make treatment of active and passive connections more uniform.). This happens because ofservice_reconfigure() loops over each ofconn in ofservice->conns and calls ofconn_reconfigure() on it to set the configuration parameters, however when ofservice_reconfigure() is called from ofservice_create(), ofservice->conns hasn't been populated yet so ofconn_reconfigure() is never called. This commit moves the ofservice_reconfigure() call to ofconn_create() where ofservice->conns is populated. This commit also removes the hardcoded default values for inactivity_probe (5s) and max_backoff (8s) on initial creation of the ofservice, as these config values are available from the ofproto_controller struct c. Signed-off-by: Brad Cowie <brad@faucet.nz> Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Simon Horman <horms@ovn.org>
2023-09-28 21:44:24 +00:00
ofservice_reconfigure(ofservice, settings);
ovs_mutex_unlock(&ofproto_mutex);
}
static void
ofconn_destroy(struct ofconn *ofconn)
OVS_REQUIRES(ofproto_mutex)
{
if (!ofconn) {
return;
}
ofconn_log_flow_mods(ofconn);
ovs_list_remove(&ofconn->connmgr_node);
ovs_list_remove(&ofconn->ofservice_node);
if (ofconn->rconn != ofconn->ofservice->rconn) {
rconn_destroy(ofconn->rconn);
}
/* Force clearing of want_packet_in_on_miss to keep the global count
* accurate. */
ofconn->controller_id = 1;
update_want_packet_in_on_miss(ofconn);
rconn_packet_counter_destroy(ofconn->packet_in_counter);
for (int i = 0; i < N_SCHEDULERS; i++) {
if (ofconn->schedulers[i]) {
pinsched_destroy(ofconn->schedulers[i]);
}
}
rconn_packet_counter_destroy(ofconn->reply_counter);
free(ofconn->async_cfg);
struct ofmonitor *monitor;
HMAP_FOR_EACH_SAFE (monitor, ofconn_node,
&ofconn->monitors) {
ofmonitor_destroy(monitor);
}
hmap_destroy(&ofconn->monitors);
rconn_packet_counter_destroy(ofconn->monitor_counter);
ofpbuf_list_delete(&ofconn->updates); /* ...but it should be empty. */
bundle_remove_all(ofconn);
hmap_destroy(&ofconn->bundles);
free(ofconn);
}
/* Reconfigures 'ofconn' to match 'c'. */
static void
ofconn_reconfigure(struct ofconn *ofconn, const struct ofproto_controller *c)
{
rconn_set_max_backoff(ofconn->rconn, c->max_backoff);
int probe_interval = c->probe_interval ? MAX(c->probe_interval, 5) : 0;
rconn_set_probe_interval(ofconn->rconn, probe_interval);
ofconn->band = c->band;
ofconn->packet_in_queue_size = c->max_pktq_size;
ofconn_set_rate_limit(ofconn, c->rate_limit, c->burst_limit);
if (c->dscp != rconn_get_dscp(ofconn->rconn)) {
rconn_set_dscp(ofconn->rconn, c->dscp);
rconn_reconnect(ofconn->rconn);
}
}
/* Returns true if it makes sense for 'ofconn' to receive and process OpenFlow
* messages. */
static bool
ofconn_may_recv(const struct ofconn *ofconn)
{
int count = rconn_packet_counter_n_packets(ofconn->reply_counter);
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
return count < OFCONN_REPLY_MAX;
}
static void
ofconn_run(struct ofconn *ofconn,
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
void (*handle_openflow)(struct ofconn *,
const struct ovs_list *msgs))
{
struct connmgr *mgr = ofconn->connmgr;
for (size_t i = 0; i < N_SCHEDULERS; i++) {
struct ovs_list txq;
pinsched_run(ofconn->schedulers[i], &txq);
do_send_packet_ins(ofconn, &txq);
}
rconn_run(ofconn->rconn);
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
/* Limit the number of iterations to avoid starving other tasks. */
for (int i = 0; i < 50 && ofconn_may_recv(ofconn); i++) {
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
struct ofpbuf *of_msg = rconn_recv(ofconn->rconn);
if (!of_msg) {
break;
}
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
if (mgr->fail_open) {
fail_open_maybe_recover(mgr->fail_open);
}
struct ovs_list msgs;
enum ofperr error = ofpmp_assembler_execute(&ofconn->assembler, of_msg,
&msgs, time_msec());
if (error) {
ofconn_send_error(ofconn, of_msg->data, error);
ofpbuf_delete(of_msg);
} else if (!ovs_list_is_empty(&msgs)) {
handle_openflow(ofconn, &msgs);
ofpbuf_list_delete(&msgs);
}
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
}
long long int now = time_msec();
if (now >= ofconn->next_bundle_expiry_check) {
ofconn->next_bundle_expiry_check = now + BUNDLE_EXPIRY_INTERVAL;
bundle_remove_expired(ofconn, now);
}
if (now >= ofconn->next_op_report) {
ofconn_log_flow_mods(ofconn);
}
struct ofpbuf *error = ofpmp_assembler_run(&ofconn->assembler,
time_msec());
if (error) {
ofconn_send(ofconn, error, NULL);
}
ovs_mutex_lock(&ofproto_mutex);
if (rconn_is_reliable(ofconn->rconn)
? !rconn_is_connected(ofconn->rconn)
: !rconn_is_alive(ofconn->rconn)) {
ofconn_destroy(ofconn);
}
ovs_mutex_unlock(&ofproto_mutex);
}
static void
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
ofconn_wait(struct ofconn *ofconn)
{
for (int i = 0; i < N_SCHEDULERS; i++) {
pinsched_wait(ofconn->schedulers[i]);
}
rconn_run_wait(ofconn->rconn);
ofproto: Do straightforward removal of asynchronous flow operations. Open vSwitch has supported datapaths that cannot update their flow tables synchronously for many versions. In that time, I have talked to many hardware implementers. None of them has ever mentioned the asynchronous interface. Furthermore, the only public hardware implementation of an Open vSwitch datapath (from Centec), does not use the asynchronous interface. At the same time, the asynchronous interface makes ofproto hard to read and hard to understand. It also makes it hard to maintain and extend. An extension in an upcoming commit would be very difficult to implement asynchronously. Therefore, this commit begins to remove the asynchronous interface. This initial commit does only the most straightforward parts of the removal, the ones that do not significantly change the structure of the code. For example, this commit does not remove the ofoperation or ofopgroup data structures at the core of the asynchronous interface, but instead reduces them to a vestigial form: where previously an ofoperation might span multiple trips through the main loop (if the operation were truly asynchronous), now it always completes immediately. The following commit will do more structural changes. It will also update all the comments, which are mostly left alone here. The hope is that this structuring of the asynchronous removal into two stages will make it easier to understand and review. If not, the commits could be squashed. Signed-off-by: Ben Pfaff <blp@nicira.com> Acked-by: Ethan Jackson <ethan@nicira.com>
2014-06-03 17:12:46 -07:00
if (ofconn_may_recv(ofconn)) {
rconn_recv_wait(ofconn->rconn);
}
if (ofconn->next_op_report != LLONG_MAX) {
poll_timer_wait_until(ofconn->next_op_report);
}
poll_timer_wait_until(ofpmp_assembler_wait(&ofconn->assembler));
}
static void
ofconn_log_flow_mods(struct ofconn *ofconn)
{
int n_flow_mods = ofconn->n_add + ofconn->n_delete + ofconn->n_modify;
if (n_flow_mods) {
long long int ago = (time_msec() - ofconn->first_op) / 1000;
long long int interval = (ofconn->last_op - ofconn->first_op) / 1000;
struct ds s;
ds_init(&s);
ds_put_format(&s, "%d flow_mods ", n_flow_mods);
if (interval == ago) {
ds_put_format(&s, "in the last %lld s", ago);
} else if (interval) {
ds_put_format(&s, "in the %lld s starting %lld s ago",
interval, ago);
} else {
ds_put_format(&s, "%lld s ago", ago);
}
ds_put_cstr(&s, " (");
if (ofconn->n_add) {
ds_put_format(&s, "%d adds, ", ofconn->n_add);
}
if (ofconn->n_delete) {
ds_put_format(&s, "%d deletes, ", ofconn->n_delete);
}
if (ofconn->n_modify) {
ds_put_format(&s, "%d modifications, ", ofconn->n_modify);
}
s.length -= 2;
ds_put_char(&s, ')');
VLOG_INFO("%s: %s", rconn_get_name(ofconn->rconn), ds_cstr(&s));
ds_destroy(&s);
ofconn->n_add = ofconn->n_delete = ofconn->n_modify = 0;
}
ofconn->next_op_report = LLONG_MAX;
}
/* Returns true if 'ofconn' should receive asynchronous messages of the given
* OAM_* 'type' and 'reason', which should be a OFPR_* value for OAM_PACKET_IN,
* a OFPPR_* value for OAM_PORT_STATUS, or an OFPRR_* value for
* OAM_FLOW_REMOVED. Returns false if the message should not be sent on
* 'ofconn'. */
static bool
ofconn_receives_async_msg(const struct ofconn *ofconn,
enum ofputil_async_msg_type type,
unsigned int reason)
{
ovs_assert(reason < 32);
ovs_assert((unsigned int) type < OAM_N_TYPES);
if (!rconn_is_connected(ofconn->rconn) || !ofconn_get_protocol(ofconn)) {
connmgr: Fix vswitchd abort when a port is added and the controller is down We see the below trace when a port is added to a bridge and the configured controller is down 0x00007fb002f8b207 in raise () from /lib64/libc.so.6 0x00007fb002f8c8f8 in abort () from /lib64/libc.so.6 0x00007fb004953026 in ofputil_protocol_to_ofp_version () from /lib64/libopenvswitch-2.10.so.0 0x00007fb00494e38e in ofputil_encode_port_status () from /lib64/libopenvswitch-2.10.so.0 0x00007fb004ef1c5b in connmgr_send_port_status () from /lib64/libofproto-2.10.so.0 0x00007fb004efa9f4 in ofport_install () from /lib64/libofproto-2.10.so.0 0x00007fb004efbfb2 in update_port () from /lib64/libofproto-2.10.so.0 0x00007fb004efc7f9 in ofproto_port_add () from /lib64/libofproto-2.10.so.0 0x0000556d540a3f95 in bridge_add_ports__ () 0x0000556d540a5a47 in bridge_reconfigure () 0x0000556d540a9199 in bridge_run () 0x0000556d540a02a5 in main () The abort is because of ofputil_protocol_to_ofp_version() is called with invalid protocol - OFPUTIL_P_NONE. Please see [1] for more details. Similar aborts are seen as reported in [2]. The commit [3] changed the behavior of the function rconn_get_version(). Before the commit [3], the function ofconn_receives_async_msg() would always return false if the connection to the controller was down, since rconn_get_version() used to return -1. This patch now checks the rconn connection status in ofconn_receives_async_msg() and returns false if not connected. This would avoid the aborts seen in the above stack trace. The issue can be reproduced by running the test added in this patch without the fix. [1] - https://bugzilla.redhat.com/show_bug.cgi?id=1640045 [2] - https://bugzilla.redhat.com/show_bug.cgi?id=1637926 [3] - 476d2551ab ("rconn: Introduce new invariant to fix assertion failure in corner case.") Signed-off-by: Numan Siddique <nusiddiq@redhat.com> Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Eelco Chaudron <echaudro@redhat.com>
2018-10-18 16:47:05 +05:30
return false;
}
/* Keep the following code in sync with the documentation in the
* "Asynchronous Messages" section in 'topics/design' */
if (ofconn->type == OFCONN_SERVICE && !ofconn->miss_send_len) {
/* Service connections don't get asynchronous messages unless they have
* explicitly asked for them by setting a nonzero miss send length. */
return false;
}
struct ofputil_async_cfg ac = ofconn_get_async_config(ofconn);
uint32_t *masks = (ofconn->role == OFPCR12_ROLE_SECONDARY
? ac.secondary
: ac.primary);
return (masks[type] & (1u << reason)) != 0;
}
/* This function returns true to indicate that a packet_in message
* for a "table-miss" should be sent to at least one controller.
*
* False otherwise. */
bool
connmgr_wants_packet_in_on_miss(struct connmgr *mgr)
{
int count;
atomic_read_relaxed(&mgr->want_packet_in_on_miss, &count);
return count > 0;
}
/* Returns a human-readable name for an OpenFlow connection between 'mgr' and
* 'target', suitable for use in log messages for identifying the connection.
*
* The name is dynamically allocated. The caller should free it (with free())
* when it is no longer needed. */
static char *
ofconn_make_name(const struct connmgr *mgr, const char *target)
{
return xasprintf("%s<->%s", mgr->name, target);
}
static void
ofconn_set_rate_limit(struct ofconn *ofconn, int rate, int burst)
{
for (int i = 0; i < N_SCHEDULERS; i++) {
struct pinsched **s = &ofconn->schedulers[i];
if (rate > 0) {
if (!*s) {
*s = pinsched_create(rate, burst);
} else {
pinsched_set_limits(*s, rate, burst);
}
} else {
pinsched_destroy(*s);
*s = NULL;
}
}
}
static void
ofconn_send(const struct ofconn *ofconn, struct ofpbuf *msg,
struct rconn_packet_counter *counter)
{
ofpmsg_update_length(msg);
rconn_send(ofconn->rconn, msg, counter);
}
/* Sending asynchronous messages. */
/* Sends an OFPT_PORT_STATUS message with 'new_pp' and 'reason' to appropriate
* controllers managed by 'mgr'. For messages caused by a controller
* OFPT_PORT_MOD, specify 'source' as the controller connection that sent the
* request; otherwise, specify 'source' as NULL.
*
* If 'reason' is OFPPR_MODIFY and 'old_pp' is nonnull, then messages are
* suppressed in the case where the change would not be visible to a particular
* controller. For example, OpenFlow 1.0 does not have the OFPPS_LIVE flag, so
* this would suppress a change solely to that flag from being sent to an
* OpenFlow 1.0 controller. */
void
connmgr_send_port_status(struct connmgr *mgr, struct ofconn *source,
const struct ofputil_phy_port *old_pp,
const struct ofputil_phy_port *new_pp,
uint8_t reason)
{
/* XXX Should limit the number of queued port status change messages. */
struct ofputil_port_status new_ps = { reason, *new_pp };
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofconn_receives_async_msg(ofconn, OAM_PORT_STATUS, reason)) {
/* Before 1.5, OpenFlow specified that OFPT_PORT_MOD should not
* generate OFPT_PORT_STATUS messages. That requirement was a
* relic of how OpenFlow originally supported a single controller,
* so that one could expect the controller to already know the
* changes it had made.
*
* EXT-338 changes OpenFlow 1.5 OFPT_PORT_MOD to send
* OFPT_PORT_STATUS messages to every controller. This is
* obviously more useful in the multi-controller case. We could
* always implement it that way in OVS, but that would risk
* confusing controllers that are intended for single-controller
* use only. (Imagine a controller that generates an OFPT_PORT_MOD
* in response to any OFPT_PORT_STATUS!)
*
* So this compromises: for OpenFlow 1.4 and earlier, it generates
* OFPT_PORT_STATUS for OFPT_PORT_MOD, but not back to the
* originating controller. In a single-controller environment, in
* particular, this means that it will never generate
* OFPT_PORT_STATUS for OFPT_PORT_MOD at all. */
if (ofconn == source
&& rconn_get_version(ofconn->rconn) < OFP15_VERSION) {
continue;
}
enum ofputil_protocol protocol = ofconn_get_protocol(ofconn);
struct ofpbuf *msg = ofputil_encode_port_status(&new_ps, protocol);
if (reason == OFPPR_MODIFY && old_pp) {
struct ofputil_port_status old_ps = { reason, *old_pp };
struct ofpbuf *old_msg = ofputil_encode_port_status(&old_ps,
protocol);
bool suppress = ofpbuf_equal(msg, old_msg);
ofpbuf_delete(old_msg);
if (suppress) {
ofpbuf_delete(msg);
continue;
}
}
ofconn_send(ofconn, msg, NULL);
}
}
}
/* Sends an OFPT_REQUESTFORWARD message with 'request' and 'reason' to
* appropriate controllers managed by 'mgr'. For messages caused by a
* controller OFPT_GROUP_MOD and OFPT_METER_MOD, specify 'source' as the
* controller connection that sent the request; otherwise, specify 'source'
* as NULL. */
void
connmgr_send_requestforward(struct connmgr *mgr, const struct ofconn *source,
const struct ofputil_requestforward *rf)
{
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
/* METER_MOD only supported in OF13 and up. */
if (rf->reason == OFPRFR_METER_MOD
&& rconn_get_version(ofconn->rconn) < OFP13_VERSION) {
continue;
}
if (ofconn_receives_async_msg(ofconn, OAM_REQUESTFORWARD, rf->reason)
&& ofconn != source) {
enum ofputil_protocol protocol = ofconn_get_protocol(ofconn);
ofconn_send(ofconn, ofputil_encode_requestforward(rf, protocol),
NULL);
}
}
}
/* Sends an OFPT_FLOW_REMOVED or NXT_FLOW_REMOVED message based on 'fr' to
* appropriate controllers managed by 'mgr'.
*
* This may be called from the RCU thread. */
void
connmgr_send_flow_removed(struct connmgr *mgr,
const struct ofputil_flow_removed *fr)
OVS_REQUIRES(ofproto_mutex)
{
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofconn_receives_async_msg(ofconn, OAM_FLOW_REMOVED, fr->reason)) {
/* Account flow expirations as replies to OpenFlow requests. That
* works because preventing OpenFlow requests from being processed
* also prevents new flows from being added (and expiring). (It
* also prevents processing OpenFlow requests that would not add
* new flows, so it is imperfect.) */
struct ofpbuf *msg = ofputil_encode_flow_removed(
fr, ofconn_get_protocol(ofconn));
ofconn_send_reply(ofconn, msg);
}
}
}
/* Sends an OFPT_TABLE_STATUS message with 'reason' to appropriate controllers
* managed by 'mgr'. When the table state changes, the controller needs to be
* informed with the OFPT_TABLE_STATUS message. The reason values
* OFPTR_VACANCY_DOWN and OFPTR_VACANCY_UP identify a vacancy message. The
* vacancy events are generated when the remaining space in the flow table
* changes and crosses one of the vacancy thereshold specified by
* OFPT_TABLE_MOD. */
void
connmgr_send_table_status(struct connmgr *mgr,
const struct ofputil_table_desc *td,
uint8_t reason)
{
struct ofputil_table_status ts = {
.reason = reason,
.desc = *td
};
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofconn_receives_async_msg(ofconn, OAM_TABLE_STATUS, reason)) {
struct ofpbuf *msg;
msg = ofputil_encode_table_status(&ts,
ofconn_get_protocol(ofconn));
if (msg) {
ofconn_send(ofconn, msg, NULL);
}
}
}
}
COVERAGE_DEFINE(connmgr_async_unsent);
/* Given 'pin', sends an OFPT_PACKET_IN message to each OpenFlow controller as
Implement serializing the state of packet traversal in "continuations". One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to send it the packet, then modify the packet and send it back to the switch to continue through the flow table. That's the theory. In practice, this doesn't work with any but the simplest flow tables. Packet-in messages simply don't include enough context to allow the flow table traversal to continue. For example: * Via "resubmit" actions, an Open vSwitch packet can have an effective "call stack", but a packet-in can't describe it, and so it would be lost. * A packet-in can't preserve the stack used by NXAST_PUSH and NXAST_POP actions. * A packet-in can't preserve the OpenFlow 1.1+ action set. * A packet-in can't preserve the state of Open vSwitch mirroring or connection tracking. This commit introduces a solution called "continuations". A continuation is the state of a packet's traversal through OpenFlow flow tables. A "controller" action with the "pause" flag, which is newly implemented in this commit, generates a continuation and sends it to the OpenFlow controller in a packet-in asynchronous message (only NXT_PACKET_IN2 supports continuations, so the controller must configure them with NXT_SET_PACKET_IN_FORMAT). The controller processes the packet-in, possibly modifying some of its data, and sends it back to the switch with an NXT_RESUME request, which causes flow table traversal to continue. In principle, a single packet can be paused and resumed multiple times. Another way to look at it is: - "pause" is an extension of the existing OFPAT_CONTROLLER action. It sends the packet to the controller, with full pipeline context (some of which is switch implementation dependent, and may thus vary from switch to switch). - A continuation is an extension of OFPT_PACKET_IN, allowing for implementation dependent metadata. - NXT_RESUME is an extension of OFPT_PACKET_OUT, with the semantics that the pipeline processing is continued with the original translation context from where it was left at the time it was paused. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 16:10:06 -08:00
* necessary according to their individual configurations. */
void
connmgr_send_async_msg(struct connmgr *mgr,
const struct ofproto_async_msg *am)
{
struct ofconn *ofconn;
bool sent = false;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
enum ofputil_protocol protocol = ofconn_get_protocol(ofconn);
if (protocol == OFPUTIL_P_NONE || !rconn_is_connected(ofconn->rconn)
|| ofconn->controller_id != am->controller_id
|| !ofconn_receives_async_msg(ofconn, am->oam,
am->pin.up.base.reason)) {
continue;
}
Implement serializing the state of packet traversal in "continuations". One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to send it the packet, then modify the packet and send it back to the switch to continue through the flow table. That's the theory. In practice, this doesn't work with any but the simplest flow tables. Packet-in messages simply don't include enough context to allow the flow table traversal to continue. For example: * Via "resubmit" actions, an Open vSwitch packet can have an effective "call stack", but a packet-in can't describe it, and so it would be lost. * A packet-in can't preserve the stack used by NXAST_PUSH and NXAST_POP actions. * A packet-in can't preserve the OpenFlow 1.1+ action set. * A packet-in can't preserve the state of Open vSwitch mirroring or connection tracking. This commit introduces a solution called "continuations". A continuation is the state of a packet's traversal through OpenFlow flow tables. A "controller" action with the "pause" flag, which is newly implemented in this commit, generates a continuation and sends it to the OpenFlow controller in a packet-in asynchronous message (only NXT_PACKET_IN2 supports continuations, so the controller must configure them with NXT_SET_PACKET_IN_FORMAT). The controller processes the packet-in, possibly modifying some of its data, and sends it back to the switch with an NXT_RESUME request, which causes flow table traversal to continue. In principle, a single packet can be paused and resumed multiple times. Another way to look at it is: - "pause" is an extension of the existing OFPAT_CONTROLLER action. It sends the packet to the controller, with full pipeline context (some of which is switch implementation dependent, and may thus vary from switch to switch). - A continuation is an extension of OFPT_PACKET_IN, allowing for implementation dependent metadata. - NXT_RESUME is an extension of OFPT_PACKET_OUT, with the semantics that the pipeline processing is continued with the original translation context from where it was left at the time it was paused. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 16:10:06 -08:00
struct ofpbuf *msg = ofputil_encode_packet_in_private(
&am->pin.up, protocol, ofconn->packet_in_format);
struct ovs_list txq;
bool is_miss = (am->pin.up.base.reason == OFPR_NO_MATCH ||
am->pin.up.base.reason == OFPR_EXPLICIT_MISS ||
am->pin.up.base.reason == OFPR_IMPLICIT_MISS);
pinsched_send(ofconn->schedulers[is_miss],
am->pin.up.base.flow_metadata.flow.in_port.ofp_port,
msg, &txq);
do_send_packet_ins(ofconn, &txq);
sent = true;
}
if (!sent) {
COVERAGE_INC(connmgr_async_unsent);
}
}
static void
do_send_packet_ins(struct ofconn *ofconn, struct ovs_list *txq)
{
struct ofpbuf *pin;
LIST_FOR_EACH_POP (pin, list_node, txq) {
if (rconn_send_with_limit(ofconn->rconn, pin,
ofconn->packet_in_counter,
ofconn->packet_in_queue_size) == EAGAIN) {
static struct vlog_rate_limit rll = VLOG_RATE_LIMIT_INIT(5, 5);
VLOG_INFO_RL(&rll, "%s: dropping packet-in due to queue overflow",
rconn_get_name(ofconn->rconn));
}
}
}
/* Fail-open settings. */
/* Returns the failure handling mode (OFPROTO_FAIL_SECURE or
* OFPROTO_FAIL_STANDALONE) for 'mgr'. */
enum ofproto_fail_mode
connmgr_get_fail_mode(const struct connmgr *mgr)
{
return mgr->fail_mode;
}
/* Sets the failure handling mode for 'mgr' to 'fail_mode' (either
* OFPROTO_FAIL_SECURE or OFPROTO_FAIL_STANDALONE). */
void
connmgr_set_fail_mode(struct connmgr *mgr, enum ofproto_fail_mode fail_mode)
{
if (mgr->fail_mode != fail_mode) {
mgr->fail_mode = fail_mode;
update_fail_open(mgr);
if (!connmgr_has_controllers(mgr)) {
ofproto_flush_flows(mgr->ofproto);
}
}
}
/* Fail-open implementation. */
/* Returns the longest probe interval among the primary controllers configured
* on 'mgr'. Returns 0 if there are no primary controllers. */
int
connmgr_get_max_probe_interval(const struct connmgr *mgr)
{
int max_probe_interval = 0;
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
if (ofservice->type == OFCONN_PRIMARY) {
int probe_interval = ofservice->s.probe_interval;
max_probe_interval = MAX(max_probe_interval, probe_interval);
}
}
return max_probe_interval;
}
/* Returns the number of seconds for which all of 'mgr's active, primary
* controllers have been disconnected. Returns 0 if 'mgr' has no active,
* primary controllers. */
int
connmgr_failure_duration(const struct connmgr *mgr)
{
int min_failure_duration = INT_MAX;
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
if (ofservice->s.type == OFCONN_PRIMARY && ofservice->rconn) {
int failure_duration = rconn_failure_duration(ofservice->rconn);
min_failure_duration = MIN(min_failure_duration, failure_duration);
}
}
return min_failure_duration != INT_MAX ? min_failure_duration : 0;
}
/* Returns true if at least one primary controller is connected (regardless of
* whether those controllers are believed to have authenticated and accepted
* this switch), false if none of them are connected. */
bool
connmgr_is_any_controller_connected(const struct connmgr *mgr)
{
struct ofservice *ofservice;
HMAP_FOR_EACH (ofservice, hmap_node, &mgr->services) {
if (ofservice->s.type == OFCONN_PRIMARY
&& !ovs_list_is_empty(&ofservice->conns)) {
return true;
}
}
return false;
}
/* Returns true if at least one primary controller is believed to have
* authenticated and accepted this switch, false otherwise. */
bool
connmgr_is_any_controller_admitted(const struct connmgr *mgr)
{
const struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofconn->type == OFCONN_PRIMARY
&& rconn_is_admitted(ofconn->rconn)) {
return true;
}
}
return false;
}
/* In-band configuration. */
static bool any_extras_changed(const struct connmgr *,
const struct sockaddr_in *extras, size_t n);
/* Sets the 'n' TCP port addresses in 'extras' as ones to which 'mgr''s
* in-band control should guarantee access, in the same way that in-band
* control guarantees access to OpenFlow controllers. */
void
connmgr_set_extra_in_band_remotes(struct connmgr *mgr,
const struct sockaddr_in *extras, size_t n)
{
if (!any_extras_changed(mgr, extras, n)) {
return;
}
free(mgr->extra_in_band_remotes);
mgr->n_extra_remotes = n;
mgr->extra_in_band_remotes = xmemdup(extras, n * sizeof *extras);
update_in_band_remotes(mgr);
}
/* Sets the OpenFlow queue used by flows set up by in-band control on
* 'mgr' to 'queue_id'. If 'queue_id' is negative, then in-band control
* flows will use the default queue. */
void
connmgr_set_in_band_queue(struct connmgr *mgr, int queue_id)
{
if (queue_id != mgr->in_band_queue) {
mgr->in_band_queue = queue_id;
update_in_band_remotes(mgr);
}
}
static bool
any_extras_changed(const struct connmgr *mgr,
const struct sockaddr_in *extras, size_t n)
{
if (n != mgr->n_extra_remotes) {
return true;
}
for (size_t i = 0; i < n; i++) {
const struct sockaddr_in *old = &mgr->extra_in_band_remotes[i];
const struct sockaddr_in *new = &extras[i];
if (old->sin_addr.s_addr != new->sin_addr.s_addr ||
old->sin_port != new->sin_port) {
return true;
}
}
return false;
}
/* In-band implementation. */
bool
connmgr_has_in_band(struct connmgr *mgr)
{
return mgr->in_band != NULL;
}
/* Fail-open and in-band implementation. */
/* Called by 'ofproto' after all flows have been flushed, to allow fail-open
* and standalone mode to re-create their flows.
*
* In-band control has more sophisticated code that manages flows itself. */
void
connmgr_flushed(struct connmgr *mgr)
OVS_EXCLUDED(ofproto_mutex)
{
if (mgr->fail_open) {
fail_open_flushed(mgr->fail_open);
}
/* If there are no controllers and we're in standalone mode, set up a flow
* that matches every packet and directs them to OFPP_NORMAL (which goes to
* us). Otherwise, the switch is in secure mode and we won't pass any
* traffic until a controller has been defined and it tells us to do so. */
if (!connmgr_has_controllers(mgr)
&& mgr->fail_mode == OFPROTO_FAIL_STANDALONE) {
struct ofpbuf ofpacts;
struct match match;
ofpbuf_init(&ofpacts, sizeof(struct ofpact_output));
ofpact_put_OUTPUT(&ofpacts)->port = OFPP_NORMAL;
match_init_catchall(&match);
ofproto_add_flow(mgr->ofproto, &match, 0, ofpacts.data,
ofpacts.size);
ofpbuf_uninit(&ofpacts);
}
}
/* Returns the number of hidden rules created by the in-band and fail-open
* implementations in table 0. (Subtracting this count from the number of
* rules in the table 0 classifier, as maintained in struct oftable, yields
* the number of flows that OVS should report via OpenFlow for table 0.) */
int
connmgr_count_hidden_rules(const struct connmgr *mgr)
{
int n_hidden = 0;
if (mgr->in_band) {
n_hidden += in_band_count_rules(mgr->in_band);
}
if (mgr->fail_open) {
n_hidden += fail_open_count_rules(mgr->fail_open);
}
return n_hidden;
}
/* Creates a new ofservice for 'target' in 'mgr'. Returns 0 if successful,
connmgr: Fix ofconn configuration on vswitchd startup. ofconn connection parameters, such as probe_interval and max_backoff, are always set to their default values when vswitchd starts up even if the user has configured these to be something different in ovsdb: $ ovs-vsctl set controller UUID inactivity_probe=9000 $ journalctl -u ovs-vswitchd.service | grep "inactivity" ovs|10895|rconn|DBG|dp1<->tcp:127.0.0.1:6653: idle 9 seconds, sending inactivity probe $ systemctl restart openvswitch-switch.service $ journalctl -u ovs-vswitchd.service | grep "inactivity" ovs|00848|rconn|DBG|dp1<->tcp:127.0.0.1:6653: idle 5 seconds, sending inactivity probe This bug was introduced by commit a0baa7df (connmgr: Make treatment of active and passive connections more uniform.). This happens because ofservice_reconfigure() loops over each ofconn in ofservice->conns and calls ofconn_reconfigure() on it to set the configuration parameters, however when ofservice_reconfigure() is called from ofservice_create(), ofservice->conns hasn't been populated yet so ofconn_reconfigure() is never called. This commit moves the ofservice_reconfigure() call to ofconn_create() where ofservice->conns is populated. This commit also removes the hardcoded default values for inactivity_probe (5s) and max_backoff (8s) on initial creation of the ofservice, as these config values are available from the ofproto_controller struct c. Signed-off-by: Brad Cowie <brad@faucet.nz> Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Simon Horman <horms@ovn.org>
2023-09-28 21:44:24 +00:00
* otherwise a positive errno value. */
static void
ofservice_create(struct connmgr *mgr, const char *target,
const struct ofproto_controller *c)
OVS_REQUIRES(ofproto_mutex)
{
struct pvconn *pvconn = NULL;
struct rconn *rconn = NULL;
if (!vconn_verify_name(target)) {
char *name = ofconn_make_name(mgr, target);
connmgr: Fix ofconn configuration on vswitchd startup. ofconn connection parameters, such as probe_interval and max_backoff, are always set to their default values when vswitchd starts up even if the user has configured these to be something different in ovsdb: $ ovs-vsctl set controller UUID inactivity_probe=9000 $ journalctl -u ovs-vswitchd.service | grep "inactivity" ovs|10895|rconn|DBG|dp1<->tcp:127.0.0.1:6653: idle 9 seconds, sending inactivity probe $ systemctl restart openvswitch-switch.service $ journalctl -u ovs-vswitchd.service | grep "inactivity" ovs|00848|rconn|DBG|dp1<->tcp:127.0.0.1:6653: idle 5 seconds, sending inactivity probe This bug was introduced by commit a0baa7df (connmgr: Make treatment of active and passive connections more uniform.). This happens because ofservice_reconfigure() loops over each ofconn in ofservice->conns and calls ofconn_reconfigure() on it to set the configuration parameters, however when ofservice_reconfigure() is called from ofservice_create(), ofservice->conns hasn't been populated yet so ofconn_reconfigure() is never called. This commit moves the ofservice_reconfigure() call to ofconn_create() where ofservice->conns is populated. This commit also removes the hardcoded default values for inactivity_probe (5s) and max_backoff (8s) on initial creation of the ofservice, as these config values are available from the ofproto_controller struct c. Signed-off-by: Brad Cowie <brad@faucet.nz> Acked-by: Eelco Chaudron <echaudro@redhat.com> Signed-off-by: Simon Horman <horms@ovn.org>
2023-09-28 21:44:24 +00:00
rconn = rconn_create(c->probe_interval, c->max_backoff,
c->dscp, c->allowed_versions);
rconn_connect(rconn, target, name);
free(name);
} else if (!pvconn_verify_name(target)) {
int error = pvconn_open(target, c->allowed_versions, c->dscp, &pvconn);
if (error) {
return;
}
} else {
VLOG_WARN_RL(&rl, "%s: unsupported controller \"%s\"",
mgr->name, target);
return;
}
struct ofservice *ofservice = xzalloc(sizeof *ofservice);
hmap_insert(&mgr->services, &ofservice->hmap_node, hash_string(target, 0));
ofservice->connmgr = mgr;
ofservice->target = xstrdup(target);
ovs_list_init(&ofservice->conns);
ofservice->type = c->type;
ofservice->rconn = rconn;
ofservice->pvconn = pvconn;
ofservice->s = *c;
VLOG_INFO("%s: added %s controller \"%s\"",
mgr->name, ofconn_type_to_string(ofservice->type), target);
}
static void
ofservice_close_all(struct ofservice *ofservice)
OVS_REQUIRES(ofproto_mutex)
{
struct ofconn *ofconn;
LIST_FOR_EACH_SAFE (ofconn, ofservice_node, &ofservice->conns) {
ofconn_destroy(ofconn);
}
}
static void
ofservice_destroy(struct ofservice *ofservice)
OVS_REQUIRES(ofproto_mutex)
{
if (!ofservice) {
return;
}
ofservice_close_all(ofservice);
hmap_remove(&ofservice->connmgr->services, &ofservice->hmap_node);
free(ofservice->target);
if (ofservice->pvconn) {
pvconn_close(ofservice->pvconn);
}
if (ofservice->rconn) {
rconn_destroy(ofservice->rconn);
}
free(ofservice);
}
static void
ofservice_run(struct ofservice *ofservice)
{
if (ofservice->pvconn) {
struct vconn *vconn;
int retval = pvconn_accept(ofservice->pvconn, &vconn);
if (!retval) {
/* Passing default value for creation of the rconn */
struct rconn *rconn = rconn_create(
ofservice->s.probe_interval, ofservice->s.max_backoff,
ofservice->s.dscp, ofservice->s.allowed_versions);
char *name = ofconn_make_name(ofservice->connmgr,
vconn_get_name(vconn));
rconn_connect_unreliably(rconn, vconn, name);
free(name);
ofconn_create(ofservice, rconn, &ofservice->s);
} else if (retval != EAGAIN) {
VLOG_WARN_RL(&rl, "accept failed (%s)", ovs_strerror(retval));
}
} else {
rconn_run(ofservice->rconn);
bool connected = rconn_is_connected(ofservice->rconn);
bool has_ofconn = !ovs_list_is_empty(&ofservice->conns);
if (connected && !has_ofconn) {
ofconn_create(ofservice, ofservice->rconn, &ofservice->s);
}
}
}
static void
ofservice_wait(struct ofservice *ofservice)
{
if (ofservice->pvconn) {
pvconn_wait(ofservice->pvconn);
}
}
static int
ofservice_reconfigure(struct ofservice *ofservice,
const struct ofproto_controller *settings)
OVS_REQUIRES(ofproto_mutex)
{
/* If the allowed OpenFlow versions change, a full cleanup is needed
* for the ofservice and connections. */
if (ofservice->s.allowed_versions != settings->allowed_versions) {
return -EINVAL;
}
ofservice->s = *settings;
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, ofservice_node, &ofservice->conns) {
ofconn_reconfigure(ofconn, settings);
}
return 0;
}
/* Finds and returns the ofservice within 'mgr' that has the given
* 'target', or a null pointer if none exists. */
static struct ofservice *
ofservice_lookup(struct connmgr *mgr, const char *target)
{
struct ofservice *ofservice;
HMAP_FOR_EACH_WITH_HASH (ofservice, hmap_node, hash_string(target, 0),
&mgr->services) {
if (!strcmp(ofservice->target, target)) {
return ofservice;
}
}
return NULL;
}
/* Flow monitors (NXST_FLOW_MONITOR). */
/* A counter incremented when something significant happens to an OpenFlow
* rule.
*
* - When a rule is added, its 'add_seqno' and 'modify_seqno' are set to
* the current value (which is then incremented).
*
* - When a rule is modified, its 'modify_seqno' is set to the current
* value (which is then incremented).
*
* Thus, by comparing an old value of monitor_seqno against a rule's
* 'add_seqno', one can tell whether the rule was added before or after the old
* value was read, and similarly for 'modify_seqno'.
*
* 32 bits should normally be sufficient (and would be nice, to save space in
* each rule) but then we'd have to have some special cases for wraparound.
*
* We initialize monitor_seqno to 1 to allow 0 to be used as an invalid
* value. */
static uint64_t monitor_seqno = 1;
COVERAGE_DEFINE(ofmonitor_pause);
COVERAGE_DEFINE(ofmonitor_resume);
enum ofperr
ofmonitor_create(const struct ofputil_flow_monitor_request *request,
struct ofconn *ofconn, struct ofmonitor **monitorp)
OVS_REQUIRES(ofproto_mutex)
{
*monitorp = NULL;
struct ofmonitor *m = ofmonitor_lookup(ofconn, request->id);
if (m) {
return OFPERR_OFPMOFC_MONITOR_EXISTS;
}
m = xmalloc(sizeof *m);
m->ofconn = ofconn;
hmap_insert(&ofconn->monitors, &m->ofconn_node, hash_int(request->id, 0));
m->id = request->id;
m->flags = request->flags;
m->out_port = request->out_port;
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
m->out_group = request->out_group;
m->table_id = request->table_id;
minimatch_init(&m->match, &request->match);
*monitorp = m;
return 0;
}
struct ofmonitor *
ofmonitor_lookup(struct ofconn *ofconn, uint32_t id)
OVS_REQUIRES(ofproto_mutex)
{
struct ofmonitor *m;
HMAP_FOR_EACH_IN_BUCKET (m, ofconn_node, hash_int(id, 0),
&ofconn->monitors) {
if (m->id == id) {
return m;
}
}
return NULL;
}
void
ofmonitor_destroy(struct ofmonitor *m)
OVS_REQUIRES(ofproto_mutex)
{
if (m) {
minimatch_destroy(&m->match);
hmap_remove(&m->ofconn->monitors, &m->ofconn_node);
free(m);
}
}
void
ofmonitor_report(struct connmgr *mgr, struct rule *rule,
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
enum ofp_flow_update_event event,
enum ofp_flow_removed_reason reason,
const struct ofconn *abbrev_ofconn, ovs_be32 abbrev_xid,
const struct rule_actions *old_actions)
OVS_REQUIRES(ofproto_mutex)
{
connmgr: Check nullptr inside ofmonitor_report(). ovs-vswitchd could crash under these circumstances: 1. When one bridge is being destroyed, ofproto_destroy() is called and connmgr pointer of its ofproto struct is nullified. This ofproto struct is deallocated through 'ovsrcu_postpone(ofproto_destroy_defer__, p);'. 2. Before RCU enters quiesce state to actually free this ofproto struct, revalidator thread calls udpif_revalidator(), which could handle a learn flow and calls ofproto_flow_mod_learn(), it later calls ofmonitor_report() and ofproto struct's connmgr pointer is accessed. The crash stack trace is shown below: 0 ofmonitor_report (mgr=0x0, rule=0x7f..30, event=NXFME_ADDED, reason=OFPRR_IDLE_TIMEOUT, abbrev_ofconn=0x0, abbrev_xid=0, old_actions=0x0) at ofproto/connmgr.c:2160 1 add_flow_finish (ofproto=0x55..b0, ofm=<optimized out>, req=0x0) at ofproto/ofproto.c:5221 2 modify_flows_finish (req=0x0, ofm=0x7f..f0, ofproto=0x55..b0) at ofproto/ofproto.c:5823 3 ofproto_flow_mod_finish (ofproto=0x55..b0, ofm=0x7f..f0, req=0x0) at ofproto/ofproto.c:8088 4 ofproto_flow_mod_learn_finish (ofm=0x7f..f0, orig_ofproto=0x0) at ofproto/ofproto.c:5439 5 ofproto_flow_mod_learn (ofm=0x7f..f0, keep_ref=true, below_limitp=0x0) at ofproto/ofproto.c:5499 6 xlate_push_stats_entry (entry=0x7f..48, stats=0x7f..10, offloaded=false) at ofproto/ofproto-dpif-xlate-cache.c:127 7 xlate_push_stats (xcache=<optimized out>, stats=0x7f..10, offloaded=false) at ofproto/ofproto-dpif-xlate-cache.c:181 8 revalidate_ukey (udpif=0x55..40, ukey=0x7f..60, stats=0x7f..18, odp_actions=0x7f..50, reval_seq=5655486242, recircs=0x7f..40, offloaded=false) at ofproto/ofproto-dpif-upcall.c:2294 9 revalidate at ofproto/ofproto-dpif-upcall.c:2683 10 udpif_revalidator at ofproto/ofproto-dpif-upcall.c:936 11 ovsthread_wrapper at lib/ovs-thread.c:423 12 start_thread () from /usr/lib64/libpthread.so.0 13 clone () from /usr/lib64/libc.so.6 At the time of crash, the involved ofproto was already deallocated: (gdb) print *ofproto $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {..., one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ... This patch fixes it. VMware-BZ: #2700626 Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Acked-by: William Tu < u9012063@gmail.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-02-17 13:09:05 -08:00
if (!mgr || rule_is_hidden(rule)) {
return;
}
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
enum ofp14_flow_monitor_flags update;
switch (event) {
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
case OFPFME_ADDED:
update = OFPFMF_ADD;
rule->add_seqno = rule->modify_seqno = monitor_seqno++;
break;
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
case OFPFME_REMOVED:
update = OFPFMF_REMOVED;
break;
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
case OFPFME_MODIFIED:
update = OFPFMF_MODIFY;
rule->modify_seqno = monitor_seqno++;
break;
default:
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
case OFPFME_INITIAL:
case OFPFME_PAUSED:
case OFPFME_RESUMED:
case OFPFME_ABBREV:
OVS_NOT_REACHED();
}
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofconn->monitor_paused) {
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
/* Only send OFPFME_REMOVED notifications for flows that were added
* before we paused. */
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
if (event != OFPFME_REMOVED
|| rule->add_seqno > ofconn->monitor_paused) {
continue;
}
}
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
enum ofp14_flow_monitor_flags flags = 0;
struct ofmonitor *m;
HMAP_FOR_EACH (m, ofconn_node, &ofconn->monitors) {
if (m->flags & update
&& (m->table_id == 0xff || m->table_id == rule->table_id)
&& (ofproto_rule_has_out_port(rule, m->out_port)
|| (old_actions
&& ofpacts_output_to_port(old_actions->ofpacts,
old_actions->ofpacts_len,
m->out_port)))
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
&& ofproto_rule_has_out_group(rule, m->out_group)
&& cls_rule_is_loose_match(&rule->cr, &m->match)) {
flags |= m->flags;
}
}
if (flags) {
if (ovs_list_is_empty(&ofconn->updates)) {
2021-12-08 18:05:22 -05:00
ofputil_start_flow_update(&ofconn->updates,
ofconn_get_protocol(ofconn));
ofconn->sent_abbrev_update = false;
}
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
if (flags & OFPFMF_ONLY_OWN || ofconn != abbrev_ofconn
|| ofconn->monitor_paused) {
struct ofputil_flow_update fu;
fu.event = event;
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
fu.reason = event == OFPFME_REMOVED ? reason : 0;
fu.table_id = rule->table_id;
fu.cookie = rule->flow_cookie;
ofproto: Fix crash on flow monitor request with tun_metadata. nx_put_match() needs a non-NULL tunnel metadata table, otherwise it will crash if a flow matches on tunnel metadata. This wasn't handled in ofputil_append_flow_update(), causing a crash when the controller sent a flow monitor request. To fix the problem, this commit changes ofputil_append_flow_update() to behave like ofputil_append_flow_stats_reply(). Since ofputil_append_flow_update() now needs to temporarily modify the match, this commits also embeds 'struct match' into 'struct ofputil_flow_update', to be safer. This is more similar to 'struct ofputil_flow_stats'. A regression test is added and a comment is updated in ovs-ofctl.c #0 0x000055699bd82fa0 in memcpy_from_metadata (dst=0x7ffc770930d0, src=0x7ffc77093698, loc=0x18) at ../lib/tun-metadata.c:451 #1 0x000055699bd83c2e in metadata_loc_from_match_read (map=0x0, match=0x7ffc77093410, idx=0, mask=0x7ffc77093658, is_masked=0x7ffc77093287) at ../lib/tun-metadata.c:848 #2 0x000055699bd83d9b in tun_metadata_to_nx_match (b=0x55699d3f0300, oxm=0, match=0x7ffc77093410) at ../lib/tun-metadata.c:871 #3 0x000055699bce523d in nx_put_raw (b=0x55699d3f0300, oxm=0, match=0x7ffc77093410, cookie=0, cookie_mask=0) at ../lib/nx-match.c:1052 #4 0x000055699bce5580 in nx_put_match (b=0x55699d3f0300, match=0x7ffc77093410, cookie=0, cookie_mask=0) at ../lib/nx-match.c:1116 #5 0x000055699bd3926f in ofputil_append_flow_update (update=0x7ffc770940b0, replies=0x7ffc77094e00) at ../lib/ofp-util.c:6805 #6 0x000055699bc4b5a9 in ofproto_compose_flow_refresh_update (rule=0x55699d405b40, flags=(NXFMF_INITIAL | NXFMF_ACTIONS), msgs=0x7ffc77094e00) at ../ofproto/ofproto.c:5915 #7 0x000055699bc4b5f6 in ofmonitor_compose_refresh_updates (rules=0x7ffc77094e10, msgs=0x7ffc77094e00) at ../ofproto/ofproto.c:5929 #8 0x000055699bc4bafc in handle_flow_monitor_request (ofconn=0x55699d404090, oh=0x55699d404220) at ../ofproto/ofproto.c:6082 #9 0x000055699bc4f46d in handle_openflow__ (ofconn=0x55699d404090, msg=0x55699d404910) at ../ofproto/ofproto.c:7912 #10 0x000055699bc4f5df in handle_openflow (ofconn=0x55699d404090, ofp_msg=0x55699d404910) at ../ofproto/ofproto.c:8002 #11 0x000055699bc88154 in ofconn_run (ofconn=0x55699d404090, handle_openflow=0x55699bc4f5bc <handle_openflow>) at ../ofproto/connmgr.c:1427 #12 0x000055699bc85934 in connmgr_run (mgr=0x55699d3adb90, handle_openflow=0x55699bc4f5bc <handle_openflow>) at ../ofproto/connmgr.c:363 #13 0x000055699bc422c9 in ofproto_run (p=0x55699d3c85e0) at ../ofproto/ofproto.c:1798 #14 0x000055699bc31ec6 in bridge_run__ () at ../vswitchd/bridge.c:2881 #15 0x000055699bc320a6 in bridge_run () at ../vswitchd/bridge.c:2938 #16 0x000055699bc3784e in main (argc=10, argv=0x7ffc770952c8) at ../vswitchd/ovs-vswitchd.c:111 Fixes: 8d8ab6c2d574 ("tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.") Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> Acked-by: Ben Pfaff <blp@ovn.org>
2016-12-27 19:02:23 -08:00
minimatch_expand(&rule->cr.match, &fu.match);
fu.priority = rule->cr.priority;
ovs_mutex_lock(&rule->mutex);
fu.idle_timeout = rule->idle_timeout;
fu.hard_timeout = rule->hard_timeout;
ovs_mutex_unlock(&rule->mutex);
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
if (flags & OFPFMF_INSTRUCTIONS) {
const struct rule_actions *actions
= rule_get_actions(rule);
fu.ofpacts = actions->ofpacts;
fu.ofpacts_len = actions->ofpacts_len;
} else {
fu.ofpacts = NULL;
fu.ofpacts_len = 0;
}
ofproto: Fix crash on flow monitor request with tun_metadata. nx_put_match() needs a non-NULL tunnel metadata table, otherwise it will crash if a flow matches on tunnel metadata. This wasn't handled in ofputil_append_flow_update(), causing a crash when the controller sent a flow monitor request. To fix the problem, this commit changes ofputil_append_flow_update() to behave like ofputil_append_flow_stats_reply(). Since ofputil_append_flow_update() now needs to temporarily modify the match, this commits also embeds 'struct match' into 'struct ofputil_flow_update', to be safer. This is more similar to 'struct ofputil_flow_stats'. A regression test is added and a comment is updated in ovs-ofctl.c #0 0x000055699bd82fa0 in memcpy_from_metadata (dst=0x7ffc770930d0, src=0x7ffc77093698, loc=0x18) at ../lib/tun-metadata.c:451 #1 0x000055699bd83c2e in metadata_loc_from_match_read (map=0x0, match=0x7ffc77093410, idx=0, mask=0x7ffc77093658, is_masked=0x7ffc77093287) at ../lib/tun-metadata.c:848 #2 0x000055699bd83d9b in tun_metadata_to_nx_match (b=0x55699d3f0300, oxm=0, match=0x7ffc77093410) at ../lib/tun-metadata.c:871 #3 0x000055699bce523d in nx_put_raw (b=0x55699d3f0300, oxm=0, match=0x7ffc77093410, cookie=0, cookie_mask=0) at ../lib/nx-match.c:1052 #4 0x000055699bce5580 in nx_put_match (b=0x55699d3f0300, match=0x7ffc77093410, cookie=0, cookie_mask=0) at ../lib/nx-match.c:1116 #5 0x000055699bd3926f in ofputil_append_flow_update (update=0x7ffc770940b0, replies=0x7ffc77094e00) at ../lib/ofp-util.c:6805 #6 0x000055699bc4b5a9 in ofproto_compose_flow_refresh_update (rule=0x55699d405b40, flags=(NXFMF_INITIAL | NXFMF_ACTIONS), msgs=0x7ffc77094e00) at ../ofproto/ofproto.c:5915 #7 0x000055699bc4b5f6 in ofmonitor_compose_refresh_updates (rules=0x7ffc77094e10, msgs=0x7ffc77094e00) at ../ofproto/ofproto.c:5929 #8 0x000055699bc4bafc in handle_flow_monitor_request (ofconn=0x55699d404090, oh=0x55699d404220) at ../ofproto/ofproto.c:6082 #9 0x000055699bc4f46d in handle_openflow__ (ofconn=0x55699d404090, msg=0x55699d404910) at ../ofproto/ofproto.c:7912 #10 0x000055699bc4f5df in handle_openflow (ofconn=0x55699d404090, ofp_msg=0x55699d404910) at ../ofproto/ofproto.c:8002 #11 0x000055699bc88154 in ofconn_run (ofconn=0x55699d404090, handle_openflow=0x55699bc4f5bc <handle_openflow>) at ../ofproto/connmgr.c:1427 #12 0x000055699bc85934 in connmgr_run (mgr=0x55699d3adb90, handle_openflow=0x55699bc4f5bc <handle_openflow>) at ../ofproto/connmgr.c:363 #13 0x000055699bc422c9 in ofproto_run (p=0x55699d3c85e0) at ../ofproto/ofproto.c:1798 #14 0x000055699bc31ec6 in bridge_run__ () at ../vswitchd/bridge.c:2881 #15 0x000055699bc320a6 in bridge_run () at ../vswitchd/bridge.c:2938 #16 0x000055699bc3784e in main (argc=10, argv=0x7ffc770952c8) at ../vswitchd/ovs-vswitchd.c:111 Fixes: 8d8ab6c2d574 ("tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.") Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> Acked-by: Ben Pfaff <blp@ovn.org>
2016-12-27 19:02:23 -08:00
ofputil_append_flow_update(&fu, &ofconn->updates,
ofproto_get_tun_tab(rule->ofproto));
} else if (!ofconn->sent_abbrev_update) {
struct ofputil_flow_update fu;
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
fu.event = OFPFME_ABBREV;
fu.xid = abbrev_xid;
ofproto: Fix crash on flow monitor request with tun_metadata. nx_put_match() needs a non-NULL tunnel metadata table, otherwise it will crash if a flow matches on tunnel metadata. This wasn't handled in ofputil_append_flow_update(), causing a crash when the controller sent a flow monitor request. To fix the problem, this commit changes ofputil_append_flow_update() to behave like ofputil_append_flow_stats_reply(). Since ofputil_append_flow_update() now needs to temporarily modify the match, this commits also embeds 'struct match' into 'struct ofputil_flow_update', to be safer. This is more similar to 'struct ofputil_flow_stats'. A regression test is added and a comment is updated in ovs-ofctl.c #0 0x000055699bd82fa0 in memcpy_from_metadata (dst=0x7ffc770930d0, src=0x7ffc77093698, loc=0x18) at ../lib/tun-metadata.c:451 #1 0x000055699bd83c2e in metadata_loc_from_match_read (map=0x0, match=0x7ffc77093410, idx=0, mask=0x7ffc77093658, is_masked=0x7ffc77093287) at ../lib/tun-metadata.c:848 #2 0x000055699bd83d9b in tun_metadata_to_nx_match (b=0x55699d3f0300, oxm=0, match=0x7ffc77093410) at ../lib/tun-metadata.c:871 #3 0x000055699bce523d in nx_put_raw (b=0x55699d3f0300, oxm=0, match=0x7ffc77093410, cookie=0, cookie_mask=0) at ../lib/nx-match.c:1052 #4 0x000055699bce5580 in nx_put_match (b=0x55699d3f0300, match=0x7ffc77093410, cookie=0, cookie_mask=0) at ../lib/nx-match.c:1116 #5 0x000055699bd3926f in ofputil_append_flow_update (update=0x7ffc770940b0, replies=0x7ffc77094e00) at ../lib/ofp-util.c:6805 #6 0x000055699bc4b5a9 in ofproto_compose_flow_refresh_update (rule=0x55699d405b40, flags=(NXFMF_INITIAL | NXFMF_ACTIONS), msgs=0x7ffc77094e00) at ../ofproto/ofproto.c:5915 #7 0x000055699bc4b5f6 in ofmonitor_compose_refresh_updates (rules=0x7ffc77094e10, msgs=0x7ffc77094e00) at ../ofproto/ofproto.c:5929 #8 0x000055699bc4bafc in handle_flow_monitor_request (ofconn=0x55699d404090, oh=0x55699d404220) at ../ofproto/ofproto.c:6082 #9 0x000055699bc4f46d in handle_openflow__ (ofconn=0x55699d404090, msg=0x55699d404910) at ../ofproto/ofproto.c:7912 #10 0x000055699bc4f5df in handle_openflow (ofconn=0x55699d404090, ofp_msg=0x55699d404910) at ../ofproto/ofproto.c:8002 #11 0x000055699bc88154 in ofconn_run (ofconn=0x55699d404090, handle_openflow=0x55699bc4f5bc <handle_openflow>) at ../ofproto/connmgr.c:1427 #12 0x000055699bc85934 in connmgr_run (mgr=0x55699d3adb90, handle_openflow=0x55699bc4f5bc <handle_openflow>) at ../ofproto/connmgr.c:363 #13 0x000055699bc422c9 in ofproto_run (p=0x55699d3c85e0) at ../ofproto/ofproto.c:1798 #14 0x000055699bc31ec6 in bridge_run__ () at ../vswitchd/bridge.c:2881 #15 0x000055699bc320a6 in bridge_run () at ../vswitchd/bridge.c:2938 #16 0x000055699bc3784e in main (argc=10, argv=0x7ffc770952c8) at ../vswitchd/ovs-vswitchd.c:111 Fixes: 8d8ab6c2d574 ("tun-metadata: Manage tunnel TLV mapping table on a per-bridge basis.") Signed-off-by: Daniele Di Proietto <diproiettod@vmware.com> Acked-by: Ben Pfaff <blp@ovn.org>
2016-12-27 19:02:23 -08:00
ofputil_append_flow_update(&fu, &ofconn->updates,
ofproto_get_tun_tab(rule->ofproto));
ofconn->sent_abbrev_update = true;
}
}
}
}
void
ofmonitor_flush(struct connmgr *mgr)
OVS_REQUIRES(ofproto_mutex)
{
struct ofconn *ofconn;
2021-12-08 18:05:22 -05:00
enum ofputil_protocol protocol;
connmgr: Check nullptr inside ofmonitor_report(). ovs-vswitchd could crash under these circumstances: 1. When one bridge is being destroyed, ofproto_destroy() is called and connmgr pointer of its ofproto struct is nullified. This ofproto struct is deallocated through 'ovsrcu_postpone(ofproto_destroy_defer__, p);'. 2. Before RCU enters quiesce state to actually free this ofproto struct, revalidator thread calls udpif_revalidator(), which could handle a learn flow and calls ofproto_flow_mod_learn(), it later calls ofmonitor_report() and ofproto struct's connmgr pointer is accessed. The crash stack trace is shown below: 0 ofmonitor_report (mgr=0x0, rule=0x7f..30, event=NXFME_ADDED, reason=OFPRR_IDLE_TIMEOUT, abbrev_ofconn=0x0, abbrev_xid=0, old_actions=0x0) at ofproto/connmgr.c:2160 1 add_flow_finish (ofproto=0x55..b0, ofm=<optimized out>, req=0x0) at ofproto/ofproto.c:5221 2 modify_flows_finish (req=0x0, ofm=0x7f..f0, ofproto=0x55..b0) at ofproto/ofproto.c:5823 3 ofproto_flow_mod_finish (ofproto=0x55..b0, ofm=0x7f..f0, req=0x0) at ofproto/ofproto.c:8088 4 ofproto_flow_mod_learn_finish (ofm=0x7f..f0, orig_ofproto=0x0) at ofproto/ofproto.c:5439 5 ofproto_flow_mod_learn (ofm=0x7f..f0, keep_ref=true, below_limitp=0x0) at ofproto/ofproto.c:5499 6 xlate_push_stats_entry (entry=0x7f..48, stats=0x7f..10, offloaded=false) at ofproto/ofproto-dpif-xlate-cache.c:127 7 xlate_push_stats (xcache=<optimized out>, stats=0x7f..10, offloaded=false) at ofproto/ofproto-dpif-xlate-cache.c:181 8 revalidate_ukey (udpif=0x55..40, ukey=0x7f..60, stats=0x7f..18, odp_actions=0x7f..50, reval_seq=5655486242, recircs=0x7f..40, offloaded=false) at ofproto/ofproto-dpif-upcall.c:2294 9 revalidate at ofproto/ofproto-dpif-upcall.c:2683 10 udpif_revalidator at ofproto/ofproto-dpif-upcall.c:936 11 ovsthread_wrapper at lib/ovs-thread.c:423 12 start_thread () from /usr/lib64/libpthread.so.0 13 clone () from /usr/lib64/libc.so.6 At the time of crash, the involved ofproto was already deallocated: (gdb) print *ofproto $1 = ..., name = 0x55d907602820 "nsx-managed", ..., ports = {..., one = 0x0, mask = 63, n = 0}, ..., connmgr = 0x0, ... This patch fixes it. VMware-BZ: #2700626 Signed-off-by: Yifeng Sun <pkusunyifeng@gmail.com> Acked-by: William Tu < u9012063@gmail.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-02-17 13:09:05 -08:00
if (!mgr) {
return;
}
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
struct rconn_packet_counter *counter = ofconn->monitor_counter;
struct ofpbuf *msg;
LIST_FOR_EACH_POP (msg, list_node, &ofconn->updates) {
ofconn_send(ofconn, msg, counter);
}
if (!ofconn->monitor_paused
&& rconn_packet_counter_n_bytes(counter) > 128 * 1024) {
COVERAGE_INC(ofmonitor_pause);
ofconn->monitor_paused = monitor_seqno++;
2021-12-08 18:05:22 -05:00
protocol = ofconn_get_protocol(ofconn);
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
struct ofpbuf *pause = ofputil_encode_flow_monitor_pause(
OFPFME_PAUSED,protocol);
ofconn_send(ofconn, pause, counter);
}
}
}
static void
ofmonitor_resume(struct ofconn *ofconn)
OVS_REQUIRES(ofproto_mutex)
{
2021-12-08 18:05:22 -05:00
enum ofputil_protocol protocol;
struct rule_collection rules;
rule_collection_init(&rules);
struct ofmonitor *m;
HMAP_FOR_EACH (m, ofconn_node, &ofconn->monitors) {
ofmonitor_collect_resume_rules(m, ofconn->monitor_paused, &rules);
}
struct ovs_list msgs = OVS_LIST_INITIALIZER(&msgs);
2021-12-08 18:05:22 -05:00
ofmonitor_compose_refresh_updates(&rules, &msgs,
ofconn_get_protocol(ofconn));
2021-12-08 18:05:22 -05:00
protocol = ofconn_get_protocol(ofconn);
ofp-monitor: Support flow monitoring for OpenFlow 1.3, 1.4+. Extended OpenFlow monitoring support * OpenFlow 1.3 with ONF extensions * OpenFlow 1.4+ as defined in OpenFlow specification 1.4+. ONF extensions are similar to Nicira extensions except for onf_flow_monitor_request{} where out_port is defined as 32-bit number OF(1.1) number, oxm match formats are used in update and request messages. Flow monitoring support in 1.4+ is slightly different from Nicira and ONF extensions. * More flow monitoring flags are defined. * Monitor add/modify/delete command is introduced in flow_monitor request message. * Addition of out_group as part of flow_monitor request message Description of changes: 1. Generate ofp-msgs.inc to be able to support 1.3, 1.4+ flow Monitoring messages. include/openvswitch/ofp-msgs.h 2. Modify openflow header files with protocol specific headers. include/openflow/openflow-1.3.h include/openflow/openflow-1.4.h 3. Modify OvS abstraction of openflow headers. ofp-monitor.h leverages enums from on nicira extensions for creating protocol abstraction headers. OF(1.4+) enums are superset of nicira extensions. include/openvswitch/ofp-monitor.h 4. Changes to these files reflect encoding and decoding of new protocol messages. lib/ofp-monitor.c 5. Changes to modules using ofp-monitor APIs. Most of the changes here are to migrate enums from nicira to OF 1.4+ versions. ofproto/connmgr.c ofproto/connmgr.h ofproto/ofproto-provider.h ofproto/ofproto.c 6. Extended protocol decoding tests to verify all protocol versions FLOW_MONITOR_CANCEL FLOW_MONITOR_PAUSED FLOW_MONITOR_RESUMED FLOW_MONITOR request FLOW_MONITOR reply tests/ofp-print.at 7. Modify flow monitoring tests to be able executed by all protocol versions. tests/ofproto.at 7. Modified documentation highlighting the change utilities/ovs-ofctl.8.in NEWS Signed-off-by: Vasu Dasari <vdasari@gmail.com> Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2021-June/383915.html Acked-by: Aaron Conole <aconole@redhat.com> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
2021-12-08 18:05:23 -05:00
struct ofpbuf *resumed = ofputil_encode_flow_monitor_pause(
OFPFME_RESUMED, protocol);
ovs_list_push_back(&msgs, &resumed->list_node);
ofconn_send_replies(ofconn, &msgs);
ofconn->monitor_paused = 0;
}
static bool
ofmonitor_may_resume(const struct ofconn *ofconn)
OVS_REQUIRES(ofproto_mutex)
{
return (ofconn->monitor_paused != 0
&& !rconn_packet_counter_n_packets(ofconn->monitor_counter));
}
static void
ofmonitor_run(struct connmgr *mgr)
{
ovs_mutex_lock(&ofproto_mutex);
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofmonitor_may_resume(ofconn)) {
COVERAGE_INC(ofmonitor_resume);
ofmonitor_resume(ofconn);
}
}
ovs_mutex_unlock(&ofproto_mutex);
}
static void
ofmonitor_wait(struct connmgr *mgr)
{
ovs_mutex_lock(&ofproto_mutex);
struct ofconn *ofconn;
LIST_FOR_EACH (ofconn, connmgr_node, &mgr->conns) {
if (ofmonitor_may_resume(ofconn)) {
poll_immediate_wake();
}
}
ovs_mutex_unlock(&ofproto_mutex);
}
void
ofproto_async_msg_free(struct ofproto_async_msg *am)
{
free(am->pin.up.base.packet);
free(am->pin.up.base.userdata);
Implement serializing the state of packet traversal in "continuations". One purpose of OpenFlow packet-in messages is to allow a controller to interpose on the path of a packet through the flow tables. If, for example, the controller needs to modify a packet in some way that the switch doesn't directly support, the controller should be able to program the switch to send it the packet, then modify the packet and send it back to the switch to continue through the flow table. That's the theory. In practice, this doesn't work with any but the simplest flow tables. Packet-in messages simply don't include enough context to allow the flow table traversal to continue. For example: * Via "resubmit" actions, an Open vSwitch packet can have an effective "call stack", but a packet-in can't describe it, and so it would be lost. * A packet-in can't preserve the stack used by NXAST_PUSH and NXAST_POP actions. * A packet-in can't preserve the OpenFlow 1.1+ action set. * A packet-in can't preserve the state of Open vSwitch mirroring or connection tracking. This commit introduces a solution called "continuations". A continuation is the state of a packet's traversal through OpenFlow flow tables. A "controller" action with the "pause" flag, which is newly implemented in this commit, generates a continuation and sends it to the OpenFlow controller in a packet-in asynchronous message (only NXT_PACKET_IN2 supports continuations, so the controller must configure them with NXT_SET_PACKET_IN_FORMAT). The controller processes the packet-in, possibly modifying some of its data, and sends it back to the switch with an NXT_RESUME request, which causes flow table traversal to continue. In principle, a single packet can be paused and resumed multiple times. Another way to look at it is: - "pause" is an extension of the existing OFPAT_CONTROLLER action. It sends the packet to the controller, with full pipeline context (some of which is switch implementation dependent, and may thus vary from switch to switch). - A continuation is an extension of OFPT_PACKET_IN, allowing for implementation dependent metadata. - NXT_RESUME is an extension of OFPT_PACKET_OUT, with the semantics that the pipeline processing is continued with the original translation context from where it was left at the time it was paused. Signed-off-by: Ben Pfaff <blp@ovn.org> Acked-by: Jarno Rajahalme <jarno@ovn.org>
2016-02-19 16:10:06 -08:00
free(am->pin.up.stack);
free(am->pin.up.actions);
free(am->pin.up.action_set);
free(am);
}